feat: add support of projecting 3D components on 2D view space #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
ktro2828
force-pushed
the
feat/viewer/projection
branch
from
aeab93a to
fd5392d
Compare
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
ktro2828
force-pushed
the
feat/viewer/projection
branch
from
fd5392d to
a04b999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pull request refactors the pointcloud rendering logic in the
Tier4visualization pipeline, primarily by removing theignore_distortionoption and simplifying how pointclouds are rendered on images. It introduces a more flexible content selection mechanism for viewers, improves code clarity, and fixes a bug in 2D annotation filtering. The changes affect the CLI, helper, and viewer modules, and update related documentation.Rendering pipeline refactor
ignore_distortionparameter fromrender_pointcloudmethods and related CLI options, streamlining the rendering API and eliminating unused pointcloud projection logic. (t4_devkit/cli/visualize.py,t4_devkit/tier4.py,t4_devkit/helper/rendering.py) [1] [2] [3] [4] [5]RenderingModeand_load_contentsinRenderingHelperto dynamically select viewer contents based on rendering mode, improving flexibility and maintainability. (t4_devkit/helper/rendering.py) [1] [2]Viewer configuration improvements
ViewerBuilder.with_spatial2dto accept acontentsargument, allowing more precise control over which entities are displayed in 2D views. (t4_devkit/viewer/builder.py)from_parent=Falsefor consistency with the rerun API. (t4_devkit/viewer/viewer.py) [1] [2]Bug fix
_render_annotation2dsto properly filter 2D annotation boxes by instance tokens, fixing a bug where unrelated boxes could be included. (t4_devkit/helper/rendering.py)Documentation update
ignore_distortionoption from the rendering tutorial. (docs/tutorials/render.md)Minor code cleanup
t4_devkit/helper/rendering.py) [1] [2]These changes collectively simplify the rendering workflow, improve viewer configurability, and address a filtering bug in annotation rendering.