Skip to content

Conversation

a-frantz
Copy link
Member

@a-frantz a-frantz commented Sep 3, 2025

Describe the problem or feature in addition to a link to the issues.

Closes #533
Started to address #510 (hence branch name) but decided to break into multiple PRs. A follow up PR is planned which will add new ExpectedMetaString and DescriptionLength rules.

Tandem PR with stjude-rust-labs/sprocket#169 (to get the full picture of this change, the sprocket PR really needs to be reviewed. Unfortunate consequence of splitting these repos 😮‍💨 )

Before submitting this PR, please make sure:

For external contributors:

  • You have read the CONTRIBUTING guide in its entirety.
  • You have not used AI on any parts of this pull request.

For all contributors:

  • You have added a few sentences describing the PR here.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these
    changes (when appropriate).
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.
  • Your PR title follows the conventional commit style.

@a-frantz a-frantz force-pushed the feat/doc-compatibility branch from 456df15 to 1f776d6 Compare September 4, 2025 01:08
@github-actions github-actions bot added the S-awaiting-CI State: awaiting the CI to pass label Sep 4, 2025
@a-frantz a-frantz changed the title [WIP]revise: lint rule toggling [WIP]feat: lint rule toggling via tags Sep 4, 2025
@a-frantz a-frantz changed the title [WIP]feat: lint rule toggling via tags feat: lint rule toggling via tags Sep 4, 2025
@a-frantz a-frantz marked this pull request as ready for review September 4, 2025 13:05
@a-frantz a-frantz requested a review from a team as a code owner September 4, 2025 13:05
@a-frantz a-frantz requested a review from peterhuene September 4, 2025 13:05
@github-actions github-actions bot removed the S-awaiting-CI State: awaiting the CI to pass label Sep 4, 2025
Copy link
Contributor

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the extraneous logging issue, I think this looks good!

@a-frantz a-frantz requested a review from peterhuene September 4, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(wdl-lint): separation of style/formatting diagnostics and semantic lints
3 participants