revise: lint rules are enabled via TagSet instead of "all" or "none"

Author: a-frantz

wdl-cli/src/analysis.rs

@@ -18,6 +18,7 @@ mod source;
 
 pub use results::AnalysisResults;
 pub use source::Source;
+use wdl_lint::TagSet;
 
 /// The type of the initialization callback.
 type InitCb = Box<dyn Fn() + 'static>;
@@ -36,8 +37,8 @@ pub struct Analysis {
     /// A list of rules to except.
     exceptions: HashSet<String>,
 
-    /// Whether or not to enable linting.
-    lint: bool,
+    /// Which lint rules to enable, as specified via a [`TagSet`].
+    enabled_lint_tags: TagSet,
 
     /// Basename for any ignorefiles which should be respected.
     ignore_filename: Option<String>,
@@ -74,12 +75,6 @@ impl Analysis {
         self
     }
 
-    /// Sets whether linting is enabled.
-    pub fn lint(mut self, value: bool) -> Self {
-        self.lint = value;
-        self
-    }
-
     /// Sets the ignorefile basename.
     pub fn ignore_filename(mut self, filename: Option<String>) -> Self {
         self.ignore_filename = filename;
@@ -104,6 +99,12 @@ impl Analysis {
         self
     }
 
+    /// Sets the enabled lint tags.
+    pub fn enabled_lint_tags(mut self, tags: TagSet) -> Self {
+        self.enabled_lint_tags = tags;
+        self
+    }
+
     /// Runs the analysis and returns all results (if any exist).
     pub async fn run(self) -> std::result::Result<AnalysisResults, NonEmpty<Arc<Error>>> {
         warn_unknown_rules(&self.exceptions);
@@ -116,8 +117,8 @@ impl Analysis {
         let validator = Box::new(move || {
             let mut validator = Validator::default();
 
-            if self.lint {
-                let visitor = get_lint_visitor(&self.exceptions);
+            if self.enabled_lint_tags.count() > 0 {
+                let visitor = get_lint_visitor(&self.enabled_lint_tags, &self.exceptions);
                 validator.add_visitor(visitor);
             }
 
@@ -150,7 +151,7 @@ impl Default for Analysis {
         Self {
             sources: Default::default(),
             exceptions: Default::default(),
-            lint: Default::default(),
+            enabled_lint_tags: TagSet::new(&[]),
             ignore_filename: None,
             init: Box::new(|| {}),
             progress: Box::new(|_, _, _| Box::pin(async {})),
@@ -195,10 +196,11 @@ fn get_diagnostics_config(exceptions: &HashSet<String>) -> DiagnosticsConfig {
 }
 
 /// Gets a lint visitor with the excepted rules removed.
-fn get_lint_visitor(exceptions: &HashSet<String>) -> Linter {
+fn get_lint_visitor(enabled_lint_tags: &TagSet, exceptions: &HashSet<String>) -> Linter {
     Linter::new(wdl_lint::rules().into_iter().filter(|rule| {
-        !exceptions
-            .iter()
-            .any(|exception| exception.eq_ignore_ascii_case(rule.id()))
+        enabled_lint_tags.union(rule.tags()).count() > 0
+            && !exceptions
+                .iter()
+                .any(|exception| exception.eq_ignore_ascii_case(rule.id()))
     }))
 }