installed python tf2_kdl and ported tf2_kdl tests #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
reviewed
Dec 17, 2019
There was a problem hiding this comment.
This is not of your doing, but this is quite a strange package. It is header-only for C++, plus some python code. I think I'd like to see this split into two packages, tf2_kdl and tf2_kdl_py. The first package would just be the header file and tests, and the second package would be a python-only package.
I don't think it would be a huge amount of work to do it in this PR, so I'd prefer to do it now. However, if you want to delay this to later, please open an issue instead. I leave the choice to you.
|
Issue created #208 |
|
|
can I squash and merge this? @clalancette |
clalancette
approved these changes
Dec 18, 2019
ahcorde
added a commit
that referenced
this pull request
Jan 23, 2020
* installed python tf2_kdl and ported tf2_kdl tests * tf2_kdl added TODO to install test
ahcorde
added a commit
that referenced
this pull request
Feb 12, 2020
* installed python tf2_kdl and ported tf2_kdl tests * tf2_kdl added TODO to install test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported