implement API for EvaluationResult protocol #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-mt
requested review from
sugyan,
yoquankara,
yustoris,
jkw552403,
keigohtr and
shimpei-yotsukura
yuki-mt
commented
Jan 8, 2019
app/models/evaluation_result.py
Outdated
| res = json.dumps(value) | ||
| else: | ||
| res = value | ||
| self._result = res |
There was a problem hiding this comment.
This is to
- get
resultas dict in Python while storing in db as string. resultcontainsresult_idin the dict
yuki-mt
changed the title
|
I resolved conflict. Please review it |
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 83.91% 81.96% -1.96%
==========================================
Files 29 30 +1
Lines 1343 1397 +54
==========================================
+ Hits 1127 1145 +18
- Misses 216 252 +36
Continue to review full report at Codecov.
|
|
we need the same version of drucker-grpc between dashboard and client to pass e2e test... So we need to do
|
|
I updated |
keigohtr
reviewed
Jan 16, 2019
keigohtr
reviewed
Jan 22, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
add method for EvaluationResult protocol to return detailed evaluation result to a client.
related to rekcurd/rekcurd-python#24
Change in frontend will be the next PR.
This PR includes
api_evaluation.pydrucker_dashboard/test/test_api_evaluation.pyf.seek(0)and reset iteration in hash_util.py to prevent StopIteration Error due to more file reading.What type of PR is it?
Feature, Bugfix
What is the issue?
N/A
How should this be tested?
python -m unittest test/test_api_evaluation.py