Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement method for EvaluationResult protocol #24

Merged
merged 7 commits into from
Jan 11, 2019

Conversation

yuki-mt
Copy link
Member

@yuki-mt yuki-mt commented Jan 8, 2019

What is this PR for?

add method for EvaluationResult protocol to return detailed evaluation result to a client.
related to rekcurd/dashboard#55

This PR includes

  • update grpc submodule to add result_path to EvaluationResultRequest grpc-proto#13
  • implement EvaluationResult method
  • make data for gRPC in get_io_by_type and get_score_by_type method
  • rename EvaluateDetail EvaluateResultDetail
  • now EvaluateDetail include input, label, EvaluateResultDetail
  • remove initial_metadata = rpc.initial_metadata() because it is never used.

What type of PR is it?

Feature

What is the issue?

How should this be tested?

python -m unittest

@yuki-mt yuki-mt self-assigned this Jan 8, 2019
Copy link
Member

@keigohtr keigohtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM

drucker/drucker_dashboard_servicer.py Show resolved Hide resolved
drucker/test/test_dashboard_servicer.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

Merging #24 into master will increase coverage by 0.55%.
The diff coverage is 94.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   87.46%   88.02%   +0.55%     
==========================================
  Files          16       16              
  Lines        1037     1152     +115     
==========================================
+ Hits          907     1014     +107     
- Misses        130      138       +8
Impacted Files Coverage Δ
drucker/utils/__init__.py 77.89% <100%> (+3.53%) ⬆️
drucker/test/test_dashboard_servicer.py 100% <100%> (ø) ⬆️
drucker/test/dummy_app.py 78.57% <80%> (-4.77%) ⬇️
drucker/drucker_worker.py 81.81% <83.33%> (-0.73%) ⬇️
drucker/drucker_dashboard_servicer.py 96.1% <89.79%> (-2.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 838542f...d6a5c3e. Read the comment docs.

Copy link
Member

@keigohtr keigohtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuki-mt yuki-mt merged commit dd7ad43 into master Jan 11, 2019
@yuki-mt yuki-mt deleted the feature/EvaluateResult_proto branch January 11, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants