-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement method for EvaluationResult protocol #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 87.46% 88.02% +0.55%
==========================================
Files 16 16
Lines 1037 1152 +115
==========================================
+ Hits 907 1014 +107
- Misses 130 138 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is this PR for?
add method for EvaluationResult protocol to return detailed evaluation result to a client.
related to rekcurd/dashboard#55
This PR includes
get_io_by_type
andget_score_by_type
methodEvaluateDetail
EvaluateResultDetail
EvaluateDetail
include input, label, EvaluateResultDetailinitial_metadata = rpc.initial_metadata()
because it is never used.What type of PR is it?
Feature
What is the issue?
How should this be tested?
python -m unittest