Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittest py37 support #60

Merged
merged 7 commits into from
Jan 22, 2019
Merged

Unittest py37 support #60

merged 7 commits into from
Jan 22, 2019

Conversation

keigohtr
Copy link
Member

What is this PR for?

Support python 3.7.
Need to upgrade pyyaml library to 3.13.

This PR includes

  • Support python 3.7
  • Upgrade libraries
  • Move test for calculating an appropriate coverage

What type of PR is it?

Feature

What is the issue?

N/A

How should this be tested?

python -m unittest

@keigohtr
Copy link
Member Author

@codecov-io
Copy link

codecov-io commented Jan 18, 2019

Codecov Report

Merging #60 into master will decrease coverage by 2.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   81.96%   79.18%   -2.78%     
==========================================
  Files          30       36       +6     
  Lines        1397     1595     +198     
==========================================
+ Hits         1145     1263     +118     
- Misses        252      332      +80
Impacted Files Coverage Δ
drucker_dashboard/_project.py 100% <0%> (ø)
drucker_dashboard/server.py 89.36% <0%> (ø)
drucker_dashboard/drucker_dashboard_client.py 69.69% <0%> (ø)
drucker_dashboard/__init__.py 100% <0%> (ø)
drucker_dashboard/app.py 0% <0%> (ø)
drucker_dashboard/_version.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d4fcd7...7c29e01. Read the comment docs.

@yuki-mt
Copy link
Member

yuki-mt commented Jan 22, 2019

@keigohtr Can you merge master branch and move drucker_dashboard/test/test_api_evaluation.py to test/test_api_evaluation.py because test_api_evaluation.py was added and test_api_application.py & test_api_service.py were removed in #55 ?
I don't know why no conflict occurs in this PR...

@keigohtr keigohtr force-pushed the fix/unittest-py37-support branch from 8c76e49 to 7c29e01 Compare January 22, 2019 06:52
@keigohtr
Copy link
Member Author

@yuki-mt I have rebased this.
Since test_api_application.py & test_api_service.py are restored, I deleted these files by hand.

Copy link
Member

@yuki-mt yuki-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keigohtr keigohtr merged commit 977aa06 into master Jan 22, 2019
@keigohtr keigohtr deleted the fix/unittest-py37-support branch January 22, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants