Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CLONE_NEWTIME to os.__all__ #13221

Merged
merged 4 commits into from
Dec 8, 2024
Merged

Conversation

tungol
Copy link
Contributor

@tungol tungol commented Dec 8, 2024

A new failure that showed up in the github runners for #13220

Looks like maybe the version of Ubuntu that the runners use got bumped? The comment in os/__init__.pyi says it's Linux 5.6+.

This comment has been minimized.

@AlexWaygood
Copy link
Member

Nice. We already pin the version of Ubuntu we use for our third-party stubtest; can we pin it for stdlib stubtest too? Something like this:

# As of 2024-10-18, ubuntu-latest can refer to different Ubuntu versions,
# which causes problems when testing gdb.
os: ["ubuntu-24.04", "windows-latest", "macos-latest"]

@AlexWaygood
Copy link
Member

(We'll want to do it in the stubtest_stdlib workflow and the daily workflow)

@tungol
Copy link
Contributor Author

tungol commented Dec 8, 2024

I don't know how much it's likely to come up again, but sure

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 8, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit edee8d3 into python:main Dec 8, 2024
95 checks passed
@tungol tungol deleted the CLONE_NEWTIME branch December 8, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants