add CLONE_NEWTIME to os.__all__ (#13221)

python · Dec 8, 2024 · edee8d3 · edee8d3
1 parent dc6b89c
commit edee8d3
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 20 deletions.
diff --git a/.github/workflows/daily.yml b/.github/workflows/daily.yml
@@ -34,7 +34,9 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: ["ubuntu-latest", "windows-latest", "macos-latest"]
+        # As of 2024-10-18, ubuntu-latest can refer to different Ubuntu versions,
+        # which can can cause problems with os module constants.
+        os: ["ubuntu-24.04", "windows-latest", "macos-latest"]
         python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
       fail-fast: false
 

diff --git a/.github/workflows/stubtest_stdlib.yml b/.github/workflows/stubtest_stdlib.yml
@@ -30,7 +30,9 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: ["ubuntu-latest", "windows-latest", "macos-latest"]
+        # As of 2024-10-18, ubuntu-latest can refer to different Ubuntu versions,
+        # which can can cause problems with os module constants.
+        os: ["ubuntu-24.04", "windows-latest", "macos-latest"]
         python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
       fail-fast: false
 

diff --git a/stdlib/@tests/stubtest_allowlists/linux-py312.txt b/stdlib/@tests/stubtest_allowlists/linux-py312.txt
@@ -1,13 +1,3 @@
-# =======
-# >= 3.12
-# =======
-
-# These seem like they should be available on Linux, but they're not
-# on GitHub Actions runners for some reason.
-os.CLONE_NEWTIME
-posix.CLONE_NEWTIME
-
-
 # =============================================================
 # Allowlist entries that cannot or should not be fixed; <= 3.12
 # =============================================================

diff --git a/stdlib/@tests/stubtest_allowlists/linux-py313.txt b/stdlib/@tests/stubtest_allowlists/linux-py313.txt
@@ -1,8 +0,0 @@
-# =======
-# >= 3.12
-# =======
-
-# These seem like they should be available on Linux, but they're not
-# on GitHub Actions runners for some reason.
-os.CLONE_NEWTIME
-posix.CLONE_NEWTIME

diff --git a/stdlib/os/__init__.pyi b/stdlib/os/__init__.pyi
@@ -231,6 +231,7 @@ if sys.platform == "linux" and sys.version_info >= (3, 12):
         "CLONE_NEWNET",
         "CLONE_NEWNS",
         "CLONE_NEWPID",
+        "CLONE_NEWTIME",
         "CLONE_NEWUSER",
         "CLONE_NEWUTS",
         "CLONE_SIGHAND",