Skip to content

Commit

Permalink
adjust allowlist for urllib.response.addbase (#13219)
Browse files Browse the repository at this point in the history
I don't think we need a regex for just two items
  • Loading branch information
tungol authored Dec 8, 2024
1 parent 4aad825 commit dc6b89c
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions stdlib/@tests/stubtest_allowlists/common.txt
Original file line number Diff line number Diff line change
Expand Up @@ -548,11 +548,8 @@ types.ModuleType.__dict__ # read-only but not actually a property; stubtest thi
types.ModuleType.__getattr__ # this doesn't exist at runtime
unittest.runner._WritelnDecorator.flush # Methods that come from __getattr__() at runtime
unittest.runner._WritelnDecorator.write # Methods that come from __getattr__() at runtime

# See comments in file. List out methods that are delegated by __getattr__ at runtime.
# Used to make the relevant class satisfy BinaryIO interface.
urllib.response.addbase.\w+

urllib.response.addbase.write # Methods that come from __getattr__() at runtime
urllib.response.addbase.writelines # Methods that come from __getattr__() at runtime
urllib.request.HTTPPasswordMgrWithPriorAuth.__init__ # Args are passed as is to super, so super args are specified
uuid.bytes_ # Attributes that are intended to be private
uuid.int_ # Attributes that are intended to be private
Expand Down

0 comments on commit dc6b89c

Please sign in to comment.