Skip to content

Exclude additional components from testSerializeOpenSimObjects that cause sporadic failure #4130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2025
Merged

Exclude additional components from testSerializeOpenSimObjects that cause sporadic failure #4130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions OpenSim/Tools/Test/testSerializeOpenSimObjects.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
#include <OpenSim/Actuators/osimActuators.h>
#include <OpenSim/Analyses/osimAnalyses.h>
#include <OpenSim/Simulation/Model/FunctionBasedPath.h>
#include <OpenSim/Simulation/Model/StationDefinedFrame.h>
#include <OpenSim/Simulation/Model/ExponentialContactForce.h>

using namespace OpenSim;
using namespace std;
Expand Down Expand Up @@ -125,6 +127,50 @@ int main()
randomize(wrap);
wrap->set_quadrant("+x");
randClone = wrap;
} else if (auto* extforce = dynamic_cast<ExternalForce*>(clone)) {
randomize(extforce);
extforce->set_force_identifier("force");
extforce->set_torque_identifier("torque");
randClone = extforce;
} else if (auto* muscle = dynamic_cast<Thelen2003Muscle*>(clone)) {
randomize(muscle);
muscle->set_Flen(1.4);
muscle->set_fv_linear_extrap_threshold(0.95);
muscle->set_minimum_activation(0.01);
muscle->set_min_control(0.01);
randClone = muscle;
} else if (auto* muscle = dynamic_cast<Millard2012EquilibriumMuscle*>(clone)) {
randomize(muscle);
muscle->set_ActiveForceLengthCurve(ActiveForceLengthCurve());
muscle->set_ForceVelocityCurve(ForceVelocityCurve());
muscle->set_FiberForceLengthCurve(FiberForceLengthCurve());
muscle->set_minimum_activation(0.01);
muscle->set_min_control(0.01);
randClone = muscle;
} else if (auto* muscle = dynamic_cast<Millard2012AccelerationMuscle*>(clone)) {
randomize(muscle);
muscle->set_ActiveForceLengthCurve(ActiveForceLengthCurve());
muscle->set_ForceVelocityCurve(ForceVelocityCurve());
muscle->set_FiberForceLengthCurve(FiberForceLengthCurve());
muscle->set_min_control(0.01);
randClone = muscle;
} else if (dynamic_cast<DeGrooteFregly2016Muscle*>(clone)) {
// TODO: we can't randomize DeGrooteFregly2016Muscle, since
// changing the the optimal_force property inherited by
// PathActuator leads to an invalid configuration.
continue;
} else if (dynamic_cast<ControlSetController*>(clone)) {
// TODO: randomizing ControlSetController fails because it is
// unable to load nonexistent file 'ABCXYZ'.
continue;
} else if (dynamic_cast<StationDefinedFrame*>(clone)) {
// TODO: randomizing StationDefinedFrame sporadically fails with
// exception message "failed to match original model".
continue;
} else if (dynamic_cast<ExponentialContactForce*>(clone)) {
// TODO: randomizing ExponentialContactForce sporadically fails
// with exception message "failed to match original model".
continue;
} else {
randClone = randomize(clone);
}
Expand Down
Loading