Skip to content

Conversation

nickbianco
Copy link
Member

@nickbianco nickbianco commented Aug 20, 2025

Brief summary of changes

Self explanatory.

Testing I've completed

Ran testSerializeOpenSimObjects locally until sporadic failures stopped occuring.

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because...internal fix.

This change is Reviewable

Copy link
Member

@carmichaelong carmichaelong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Looks good to me as is, so I'm approving. Thanks for carefully combing through those intermittent issues.

Some ideas (could be a separate PR):

  • Seems like for at least one these objects, the issue is even applying a random set of values. Would it be fair to keep trying random sets until a valid one is reached?
  • More broadly, for the purpose of this test, is randomization necessary (or just a stronger conditions)? If not, should we assign specific values that work and it'll still test the serialization/deserialization steps?

@carmichaelong reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nickbianco)

@nickbianco nickbianco merged commit c34fa05 into opensim-org:main Aug 27, 2025
11 checks passed
@nickbianco nickbianco deleted the test_serialize_opensim_objects_patch branch August 27, 2025 18:07
@nickbianco
Copy link
Member Author

Thanks @carmichaelong. I've opened #4137 to capture the larger issue with this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants