updates for the "Korg Kaoss DJ" controller script #12683

daschuer · 2024-01-29T09:10:13Z

New assignments:


`browser Knob`	browse library or playlist up & down (same as before)
`shift` + `browser Knob`	toggle focus between Playlist and File-Browser


`tap`	open folder
2 x `tap`	close folder
`(left) shift` + `tap`	tap bpm of left track
`(right) shift` + `tap`	tap bpm of right track


`load A / B`	load track to deck 1 / 2 (same as before)
`shift` + `load A / B`	open / close folder in file-browser


`shift` + `touchpad X`	control super knob of QuickEffectRack for deck 1
`shift` + `touchpad Y`	control super knob of QuickEffectRack for deck 2

changed assignments

the loop-on button now works as follows:
- if a loop is active, it deactivates the loop (same as before)
- if no loop is active, a new beatloop is created at the current playback position
  (before a re-loop of the deactivated loop was triggered)

doc-updates:

mixxxdj/manual#430

<TAP> : open folder <TAP> + <TAP> : double-tap to close folder <SHIFT LEFT> + <TAP> : tap bpm of LEFT track <SHIFT RIGHT> + <TAP> : tap bpm of RIGHT track <browseKnob> : browse library up & down <SHIFT> + <browseKnob> : toggle focus between Playlist and File-Browser <LOAD A/B> : load track <SHIFT> + <LOAD A/B> : open/close folder in file-browser

<SHIFT> + <TOUCHPAD X> : control super knob of QuickEffectRack for deck 1 <SHIFT> + <TOUCHPAD Y> : control super knob of QuickEffectRack for deck 2

…s-dj-revamp

daschuer · 2024-01-29T09:14:36Z

@pi43r Please Test and share your results. Do you have interest to take over?

pi43r · 2024-01-30T09:27:53Z

Thanks for opening this again!
I can try it on my controller but it might take some time. There also seems to be new interest in the forum.

I would need to get familiar with scripting for mixxx but I could definitely try updating the docs if I find anything.

Swiftb0y · 2024-01-30T12:48:14Z

@daschuer for me as a reviewer: are you trying to just get this merged or do you want to receive suggestions on potential improvements before merging?

daschuer · 2024-01-30T14:11:42Z

I have no clue about the code here. This PR is just to save the commits from oblivion and that someone else can easily take over.

Swiftb0y

mergeable otherwise. thank you.

res/controllers/Korg-KAOSS-DJ-scripts.js

Swiftb0y · 2024-01-30T18:08:19Z

res/controllers/Korg-KAOSS-DJ-scripts.js

+    const now = new Date();
+    const timeSinceLastTap = now - KAOSSDJ.lastTapDate;
+    KAOSSDJ.lastTapDate = now;
+    if ((timeSinceLastTap < 600) && (timeSinceLastTap > 0)) {
+        engine.setValue("[Library]", "MoveLeft", true);
+    } else {
+        engine.setValue("[Library]", "MoveRight", true);
+    }


maybe GoToItem + Back would be better?

We have no "Back" AFAIK. I leave this for one who can test this.

Not really, but we have [Library], MoveFocusBackward which is commonly mapped I think.

Swiftb0y · 2024-01-30T18:10:26Z

I have no clue about the code here. This PR is just to save the commits from oblivion and that someone else can easily take over.

Good to know. I doubt anyone else would be interested, so lets fix the easy things and get this merged.

Swiftb0y

thank you. almost lgtm. Just fix the typo and the fxGroup string above (otherwise it will not get interpreted correctly and KAOSSDJ.fxTouch will be broken).

res/controllers/Korg-KAOSS-DJ-scripts.js

daschuer · 2024-02-04T12:13:14Z

Thank you for review. I have amended the isFX issue. I hope that is OK here.

Swiftb0y · 2024-02-04T12:52:38Z

yup sure. only remaining issue is the unresolved fxGroup issue from my previous review.

Co-authored-by: Swiftb0y <[email protected]>

daschuer · 2024-02-04T13:03:40Z

Done.

Swiftb0y

good job to eslint for catching this one.

res/controllers/Korg-KAOSS-DJ.midi.xml

res/controllers/Korg-KAOSS-DJ-scripts.js

Co-authored-by: Swiftb0y <[email protected]>

Swiftb0y

LGTM. At least this shouldn't have worsened the current version. Lets just merge and see if users notice anything.

Swiftb0y · 2024-02-04T14:29:29Z

@daschuer are you also volunteering to adopt the corresponding manual PR? mixxxdj/manual#430

daschuer · 2024-02-04T19:03:59Z

No sorry, that needs to be really done by one owning such controller. I think also some testing would be not hurt here.

Swiftb0y · 2024-02-04T19:37:14Z

@raphaelquast do you still have access to the controller and can test the current version of the mapping? Do you have time to finish the manual page?

raphaelquast · 2024-02-04T22:08:43Z

@Swiftb0y
I do still own the controller but i'm very limited in time at the moment... (and it seems like it's going to be like this for a while)
If a functionality test from someone owning the controller is the only thing that's blocking this from merging then I can try to find some time to have a quick look... but unfortunately I'm not able to actively contribute in the near future.

pi43r · 2024-02-12T09:13:23Z

I can confirm operation of the new script in Mixxx 4.0.16 on Fedora39.
I couldn't test on MacOs because I'm not able to install the midi driver on my M2 macbook.
Will edit this for Windows when I get to it.

My findings, most of them pretty minor:

Moving between levels using Knob [4] + shift needs retriggering of shift after every change
Display is off. (Should indicate FX number or param / key or scale. I don't recall this ever to be the case in the past)
Program Knob [7] does nothing? (supposed to select effect or change key, might be talking about the internal kaoss pad)
Touchpad [10] does nothing. It should change the super FX knobs. (works with the old script)
Shift + Play = Key lock not working (doesn't work in old script either)
Shift + Sync = Cancels Sync does not work. Pressing sync cancels it. (Maybe it's just an issue with the docs?)

So the main issue is the center touchpad functionality.

Swiftb0y · 2024-02-12T10:59:52Z

Hi @pi43r. Thank you for taking the time to test this mapping.

Mixxx 4.0.16

Where did you get that version number from, that doesn't look right.

Moving between levels using Knob [4] + shift needs retriggering of shift after every change

Can you elaborate on what you mean by "retriggering of shift"? What behavior do you expect as working normally? how does it behave instead currently?

Display is off. (Should indicate FX number or param / key or scale. I don't recall this ever to be the case in the past)

Yeah, I don't think the original mapper bothered to try to understand how that works. Someone with access to the hardware and some basic reverse-engineering skills would have to figure that out.

Program Knob [7] does nothing? (supposed to select effect or change key, might be talking about the internal kaoss pad)

Thank you for your testing. I'll try to see what I can fix remotely. In the meantime, I see you have already opened mixxxdj/manual#613. Would you be interested in incorporating the changes made here into that PR as well?

Swiftb0y · 2024-02-12T11:06:25Z

Shift + Play = Key lock not working (doesn't work in old script either)
Shift + Sync = Cancels Sync does not work. Pressing sync cancels it. (Maybe it's just an issue with the docs?)

Those currently seem to be unimplemented for the sake of simplicity. Do you think they're necessary or can we just cut that feature from the docs?

res/controllers/Korg-KAOSS-DJ-scripts.js

pi43r · 2024-02-12T11:32:36Z

Mixxx 4.0.16
Where did you get that version number from, that doesn't look right.

Copied it from human memory :) It should be 2.4.0 (0.16.beta.20240209gitd112e4c.fc39)
https://koji.rpmfusion.org/koji/buildinfo?buildID=28064

Moving between levels using Knob [4] + shift needs retriggering of shift after every change

Can you elaborate on what you mean by "retriggering of shift"? What behavior do you expect as working normally? how does it behave instead currently?

Holding shift + knob 4 changes from Browser to Search to the Folder window. This change only happens once. I have to release shift and press it again in order to highlight the next "level". I would expect it to cycle through them as long as it shift is pressed.

Those currently seem to be unimplemented for the sake of simplicity. Do you think they're necessary or can we just cut that feature from the docs?

Works well without it. Key lock would be nice though

Would you be interested in incorporating the changes made here into that PR as well?

Sure, I can edit the manual

Swiftb0y

LGTM. Thank you.

Swiftb0y · 2024-05-23T18:05:20Z

I partly wrote this PR @daschuer so I'll let you decide whether to merge.

daschuer · 2024-05-24T05:28:10Z

Thank you. I see no reason to hold that back.

raphaelquast · 2024-05-24T09:05:11Z

@ALL really nice to see that the changes for to the Korg Kaoss DJ script have made it to the finish line! Thanks for following up on my initial PR (and sorry for not being able to finish it myself in reasonable time)!

daschuer · 2024-05-26T07:05:38Z

@pi43r I have noticed we have not ask you for the formal confirmation to distribute your work with Mixxx.
Can you please sign https://docs.google.com/a/mixxx.org/spreadsheet/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ and comment here when done?
Thank you.

raphaelquast and others added 16 commits July 4, 2023 13:27

add looping function

57b66d8

add functions to control QuickEffectRack super knobs

68f5e66

<SHIFT> + <TOUCHPAD X> : control super knob of QuickEffectRack for deck 1 <SHIFT> + <TOUCHPAD Y> : control super knob of QuickEffectRack for deck 2

update controller-assignments .xml file

bd3492a

korg-kaoss-dj: Fix Fx knob binding

431fd7e

korg-kaoss-dj: Reformat code and fix eslint issues

71e6d1c

korg-kaoss-dj: Rename script binding functions

9ce9e04

korg-kaoss-dj: Simplify and reformat code

4bedd10

korg-kaoss-dj: Fix handling of resetting the efx params on release

138b6cd

korg-kaoss-dj: Simplify handling of Fx toggle buttons

0b64919

korg-kaoss-dj: Fix eslint issues

5c7154e

korg-kaoss-dj: Simplify JS code by switching to ES7

7b8f587

korg-kaoss-dj: Fix ESLint issues

f4c20b4

korg-kaoss-dj: Fix ESLint warning

99f4974

korg-kaoss-dj: use ES6 template literals

5e45e1b

Merge branch '2.4' of [email protected]:mixxxdj/mixxx.git into korg-kaos…

bcc8634

…s-dj-revamp

github-actions bot added the controller mappings label Jan 29, 2024

daschuer changed the base branch from main to 2.4 January 29, 2024 09:11

Swiftb0y reviewed Jan 30, 2024

View reviewed changes

Swiftb0y reviewed Feb 4, 2024

View reviewed changes

res/controllers/Korg-KAOSS-DJ-scripts.js Outdated Show resolved Hide resolved

daschuer added 5 commits February 4, 2024 13:11

Rename fx to isFx

ac7e5d6

Remove redundant Object.values()

bde8811

Inline loopEnabled

7e9abd8

Update comment

18e8199

Merge remote-tracking branch 'upstream/2.4' into korg-kaoss-dj

d81b1b3

daschuer force-pushed the korg-kaoss-dj branch from 9d70945 to d81b1b3 Compare February 4, 2024 12:12

Use single quotes

ab7690d

Co-authored-by: Swiftb0y <[email protected]>

Swiftb0y requested changes Feb 4, 2024

View reviewed changes

res/controllers/Korg-KAOSS-DJ.midi.xml Show resolved Hide resolved

res/controllers/Korg-KAOSS-DJ.midi.xml Show resolved Hide resolved

res/controllers/Korg-KAOSS-DJ-scripts.js Outdated Show resolved Hide resolved

daschuer and others added 2 commits February 4, 2024 14:36

fix error 'deck' is not defined

b5e78de

Co-authored-by: Swiftb0y <[email protected]>

Fix xml mappings

6543c80

Co-authored-by: Swiftb0y <[email protected]>

Swiftb0y approved these changes Feb 4, 2024

View reviewed changes

Swiftb0y requested changes Feb 12, 2024

View reviewed changes

res/controllers/Korg-KAOSS-DJ-scripts.js Outdated Show resolved Hide resolved

res/controllers/Korg-KAOSS-DJ-scripts.js Outdated Show resolved Hide resolved

pi43r mentioned this pull request Feb 13, 2024

Add FX Knob Script to "Korg Kaoss DJ" #12807

Closed

3 tasks

feat: implement fxknob

da49233

Swiftb0y force-pushed the korg-kaoss-dj branch from 98d01ad to da49233 Compare February 15, 2024 20:18

ronso0 added this to the 2.4.2 milestone Apr 13, 2024

Swiftb0y approved these changes May 23, 2024

View reviewed changes

daschuer merged commit 40fa8dd into 2.4 May 24, 2024
25 checks passed

Swiftb0y deleted the korg-kaoss-dj branch May 24, 2024 08:13

ronso0 mentioned this pull request May 26, 2024

updates for the "Korg Kaoss DJ" controller script #4301

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updates for the "Korg Kaoss DJ" controller script #12683

updates for the "Korg Kaoss DJ" controller script #12683

daschuer commented Jan 29, 2024

daschuer commented Jan 29, 2024

pi43r commented Jan 30, 2024

Swiftb0y commented Jan 30, 2024

daschuer commented Jan 30, 2024

Swiftb0y left a comment

Swiftb0y Jan 30, 2024

daschuer Feb 4, 2024

Swiftb0y Feb 4, 2024

Swiftb0y commented Jan 30, 2024

Swiftb0y left a comment

daschuer commented Feb 4, 2024

Swiftb0y commented Feb 4, 2024

daschuer commented Feb 4, 2024

Swiftb0y left a comment

Swiftb0y left a comment

Swiftb0y commented Feb 4, 2024

daschuer commented Feb 4, 2024

Swiftb0y commented Feb 4, 2024

raphaelquast commented Feb 4, 2024

pi43r commented Feb 12, 2024

Swiftb0y commented Feb 12, 2024

Swiftb0y commented Feb 12, 2024

pi43r commented Feb 12, 2024 •

edited

Loading

Swiftb0y left a comment

Swiftb0y commented May 23, 2024

daschuer commented May 24, 2024

raphaelquast commented May 24, 2024

daschuer commented May 26, 2024

updates for the "Korg Kaoss DJ" controller script #12683

updates for the "Korg Kaoss DJ" controller script #12683

Conversation

daschuer commented Jan 29, 2024

New assignments:

changed assignments

doc-updates:

daschuer commented Jan 29, 2024

pi43r commented Jan 30, 2024

Swiftb0y commented Jan 30, 2024

daschuer commented Jan 30, 2024

Swiftb0y left a comment

Choose a reason for hiding this comment

Swiftb0y Jan 30, 2024

Choose a reason for hiding this comment

daschuer Feb 4, 2024

Choose a reason for hiding this comment

Swiftb0y Feb 4, 2024

Choose a reason for hiding this comment

Swiftb0y commented Jan 30, 2024

Swiftb0y left a comment

Choose a reason for hiding this comment

daschuer commented Feb 4, 2024

Swiftb0y commented Feb 4, 2024

daschuer commented Feb 4, 2024

Swiftb0y left a comment

Choose a reason for hiding this comment

Swiftb0y left a comment

Choose a reason for hiding this comment

Swiftb0y commented Feb 4, 2024

daschuer commented Feb 4, 2024

Swiftb0y commented Feb 4, 2024

raphaelquast commented Feb 4, 2024

pi43r commented Feb 12, 2024

Swiftb0y commented Feb 12, 2024

Swiftb0y commented Feb 12, 2024

pi43r commented Feb 12, 2024 • edited Loading

Swiftb0y left a comment

Choose a reason for hiding this comment

Swiftb0y commented May 23, 2024

daschuer commented May 24, 2024

raphaelquast commented May 24, 2024

daschuer commented May 26, 2024

pi43r commented Feb 12, 2024 •

edited

Loading