Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FX Knob Script to "Korg Kaoss DJ" #12807

Closed
wants to merge 5 commits into from

Conversation

pi43r
Copy link
Contributor

@pi43r pi43r commented Feb 13, 2024

Based on #12683
The FX knob now functions as follows:
[no shift] Cycles QuickEffects of Channel 1 + 2
[left shift] Cycles chains on EffectUnit1
[right shift] Cycles chains on EffectUnit2

With this integrated I think the script is now in a state of merging.
I would still need to change the manual to reflect on this last change.

Some future improvements could be:

  • Get the display to work
  • add functions to Shift + Play/Sync/Cue
  • Hold (Button 9) not mapped in ControllerFX mode

@Swiftb0y
Copy link
Member

Welcome and thanks for improving this! Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

@Swiftb0y
Copy link
Member

Some future improvements could be:

Yes. please add them in this PR if you're interested in having them.

@pi43r
Copy link
Contributor Author

pi43r commented Feb 13, 2024

Some future improvements could be:
Yes. please add them in this PR if you're interested in having them.

I don't really know how and don't have the time to work on it extensively at the moment. Just left these suggestions there for later reference.

As mentioned in the previous PR, it would be nice to get this merged to 2.4.
As far as I see it only needs linting and changing the manual?

I signed the agreement.
Thank you

@Swiftb0y
Copy link
Member

As mentioned in the previous PR, it would be nice to get this merged to 2.4.

Sure, if it doesn't make it into 2.4.0, it will go into 2.4.1 or whatever the next release will be then.

As far as I see it only needs linting and changing the manual?

Yup. That would be great if you could take care of that.

@Swiftb0y
Copy link
Member

@daschuer a squash merge would be most appropriate here...

@Swiftb0y
Copy link
Member

I manually squashed your commits and merged them into the kaoss-dj PR. Thanks for your work.

@Swiftb0y Swiftb0y closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants