improve readabality #430 add standby notice #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
reviewed
Feb 12, 2024
| @@ -26,6 +26,7 @@ Mapping | |||
| Korg Kaoss DJ (schematic view) | |||
|
|
|||
|
|
|||
| <<<<<<< Updated upstream | |||
There was a problem hiding this comment.
There's some residue from conflict resolution
|
fixed the unexpected merge error. |
|
FX button based on mixxxdj/mixxx#12807 Looks good to me now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't figure out how to add line breaks either. But this should be slightly better.
Also added a notice that the controller only starts working when set as output device (after which one can remove it, and it still works as a midi controller)
edit(ronso0) based on #430