Squashed commit of the following:

commit 1dd21d4 Author: ms <[email protected]> Date: Thu Feb 15 02:17:19 2024 +0900 lint: rm space commit 6b0baad Author: ms <[email protected]> Date: Thu Feb 15 01:18:17 2024 +0900 lint issues 2 commit 61394bd Author: ms <[email protected]> Date: Thu Feb 15 00:46:48 2024 +0900 fix linting commit 2a66f42 Author: pitscher <[email protected]> Date: Tue Feb 13 03:45:26 2024 +0100 fix fx toggle commit 8383f1e Author: pitscher <[email protected]> Date: Tue Feb 13 03:22:43 2024 +0100 fx knob script
mixxxdj · Feb 15, 2024 · 98d01ad · 98d01ad
1 parent 6543c80
commit 98d01ad
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 4 deletions.
diff --git a/res/controllers/Korg-KAOSS-DJ-scripts.js b/res/controllers/Korg-KAOSS-DJ-scripts.js
@@ -181,11 +181,34 @@ KAOSSDJ.scratchMode = function(channel, _control, value, _status, _group) {
 };
 
 KAOSSDJ.fxToggleButton = function(channel, _control, value, _status, _group) {
-    KAOSSDJ.updateDeckByChannel(channel, "fx", value === MIDI_ON);
+    KAOSSDJ.updateDeckByChannel(channel, "isFx", value === MIDI_ON);
 };
 
-KAOSSDJ.fxKnob = function(_channel, _control, _value, _status) {
-    // TODO
+KAOSSDJ.fxKnob = function(_channel, _control, value, _status, _group) {
+    if (KAOSSDJ.shiftLeftPressed) {
+        // If Left Shift is pressed, cycle the effects chains on EffectUnit1
+        if (value === MIDI_UP) {
+            engine.setValue("[EffectRack1_EffectUnit1]", "next_chain", 1);
+        } else if (value === MIDI_DOWN) {
+            engine.setValue("[EffectRack1_EffectUnit1]", "prev_chain", 1);
+        }
+    } else if (KAOSSDJ.shiftRightPressed) {
+        // If Right Shift is not pressed, cycle the effects chains on EffectUnit2
+        if (value === MIDI_UP) {
+            engine.setValue("[EffectRack1_EffectUnit2]", "next_chain", 1);
+        } else if (value === MIDI_DOWN) {
+            engine.setValue("[EffectRack1_EffectUnit2]", "prev_chain", 1);
+        }
+    } else {
+        // If no shift is pressed, cycle through both QuickEffectRack filters
+        if (value === MIDI_UP) {
+            engine.setValue("[QuickEffectRack1_[Channel1]]", "next_chain", 1);
+            engine.setValue("[QuickEffectRack1_[Channel2]]", "next_chain", 1);
+        } else if (value === MIDI_DOWN) {
+            engine.setValue("[QuickEffectRack1_[Channel1]]", "prev_chain", 1);
+            engine.setValue("[QuickEffectRack1_[Channel2]]", "prev_chain", 1);
+        }
+    }
 };
 
 KAOSSDJ.fxTouchMoveVertical = function(_channel, _control, value, _status, _group) {

diff --git a/res/controllers/Korg-KAOSS-DJ.midi.xml b/res/controllers/Korg-KAOSS-DJ.midi.xml
@@ -625,7 +625,7 @@
                 <status>0xB6</status>
                 <midino>0x1F</midino>
                 <options>
-                    <normal/>
+                    <script-binding/>
                 </options>
             </control>
             <control>