Update build_steps.yml fix condition #2300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grusev
changed the title
G-D-Petrov
approved these changes
Apr 8, 2025
G-D-Petrov
reviewed
Apr 8, 2025
| - name: Remove AWS testing account and credentials | ||
| if: always() && inputs.persistent_storage == 'true' && matrix.os == 'windows' | ||
| run: | | ||
| echo "env.real_tests_enabled: [${{ env.real_tests_enabled }}]" |
Collaborator
There was a problem hiding this comment.
This is not really needed as GH already prints the env vars that are used in a given step
phoebusm
reviewed
Apr 8, 2025
.github/workflows/build_steps.yml
Outdated
|
|
||
| # Fallback if the clean up at test fixutre tear down fails due to crash or etc | ||
| - name: Remove AWS testing account and credentials | ||
| if: always() && inputs.persistent_storage == 'true' && matrix.os == 'windows' |
Collaborator
There was a problem hiding this comment.
I think the condition of running Set s3 sts persistent storage variables for Windows and Remove AWS testing account and credentials should align
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...