Skip to content

Commit 103ef93

Browse files
grusevG-D-Petrov
andauthored
Update build_steps.yml fix condition (#2300)
#### Reference Issues/PRs <!--Example: Fixes #1234. See also #3456.--> #### What does this implement or fix? #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing --> --------- Co-authored-by: Georgi Petrov <[email protected]>
1 parent e353b0b commit 103ef93

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

.github/workflows/analysis_workflow.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,7 @@ jobs:
145145
ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.sha || '' }} # Note: This is dangerous if we run automatic CI on external PRs
146146

147147
- name: Configure sccache
148-
uses: mozilla-actions/[email protected]
149-
with:
150-
version: "v0.4.0"
148+
uses: mozilla-actions/[email protected]
151149

152150
- name: Extra envs
153151
shell: bash -l {0}

.github/workflows/benchmark_commits.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,7 @@ jobs:
4343
ref: ${{ inputs.run_on_pr_head && github.event.pull_request.head.sha || '' }} # Note: This is dangerous if we run automatic CI on external PRs
4444

4545
- name: Configure sccache
46-
uses: mozilla-actions/[email protected]
47-
with:
48-
version: "v0.4.0"
46+
uses: mozilla-actions/[email protected]
4947

5048
- name: Extra envs
5149
shell: bash -l {0}

.github/workflows/build_steps.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ jobs:
341341
CMAKE_BUILD_PARALLEL_LEVEL: ${{vars.CMAKE_BUILD_PARALLEL_LEVEL}}
342342

343343
- name: Set persistent storage variables
344-
if: ${{ env.real_tests_enabled }} != 'no'
344+
if: ${{ env.real_tests_enabled != 'no' }}
345345
uses: ./.github/actions/set_persistent_storage_env_vars
346346
with:
347347
aws_access_key: "${{ secrets.AWS_S3_ACCESS_KEY }}"
@@ -352,7 +352,7 @@ jobs:
352352
strategy_branch: "${{ env.distinguishing_name }}"
353353

354354
- name: Set s3 sts persistent storage variables for Windows
355-
if: ${{ env.real_tests_enabled }} != 'no' && matrix.os == 'windows'
355+
if: ${{ env.real_tests_enabled != 'no' && matrix.os == 'windows' }}
356356
uses: ./.github/actions/set_s3_sts_persistent_storage_env_vars
357357
with:
358358
aws_access_key: "${{ secrets.AWS_S3_ACCESS_KEY }}"
@@ -378,8 +378,9 @@ jobs:
378378

379379
# Fallback if the clean up at test fixutre tear down fails due to crash or etc
380380
- name: Remove AWS testing account and credentials
381-
if: always() && inputs.persistent_storage == 'true' && matrix.os == 'windows'
381+
if: ${{ always() && env.real_tests_enabled != 'no' && matrix.os == 'windows' }}
382382
run: |
383+
echo "env.real_tests_enabled: [${{ env.real_tests_enabled }}]"
383384
python -c "
384385
from arcticdb.storage_fixtures.s3 import real_s3_sts_clean_up
385386
real_s3_sts_clean_up('${ARCTICDB_REAL_S3_STS_TEST_USERNAME}', '${ARCTICDB_REAL_S3_STS_TEST_ROLE}', '${ARCTICDB_REAL_S3_STS_TEST_POLICY_NAME}')

0 commit comments

Comments
 (0)