Skip to content

Update build_steps.yml fix condition #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
G-D-Petrov merged 7 commits into from
Apr 8, 2025
Merged

Update build_steps.yml fix condition #2300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ef194dd
Update build_steps.yml add double quotes
grusev Apr 8, 2025
3c99bb5
Update build_steps.yml fix condition
grusev Apr 8, 2025
ba85a15
Update build_steps.yml fix condition
grusev Apr 8, 2025
70e8d13
fix STS remove steps
grusev Apr 8, 2025
0648a8d
Use the latest sccache in the benchmark flows
G-D-Petrov Apr 8, 2025
fe7ef14
Update build_steps.yml
grusev Apr 8, 2025
51c7827
not eq to no
grusev Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/analysis_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,7 @@ jobs:
ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.sha || '' }} # Note: This is dangerous if we run automatic CI on external PRs

- name: Configure sccache
uses: mozilla-actions/sccache-action@v0.0.3
with:
version: "v0.4.0"
uses: mozilla-actions/sccache-action@v0.0.9

- name: Extra envs
shell: bash -l {0}
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/benchmark_commits.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@ jobs:
ref: ${{ inputs.run_on_pr_head && github.event.pull_request.head.sha || '' }} # Note: This is dangerous if we run automatic CI on external PRs

- name: Configure sccache
uses: mozilla-actions/sccache-action@v0.0.3
with:
version: "v0.4.0"
uses: mozilla-actions/sccache-action@v0.0.9

- name: Extra envs
shell: bash -l {0}
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/build_steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ jobs:
CMAKE_BUILD_PARALLEL_LEVEL: ${{vars.CMAKE_BUILD_PARALLEL_LEVEL}}

- name: Set persistent storage variables
if: ${{ env.real_tests_enabled }} != 'no'
if: ${{ env.real_tests_enabled != 'no' }}
uses: ./.github/actions/set_persistent_storage_env_vars
with:
aws_access_key: "${{ secrets.AWS_S3_ACCESS_KEY }}"
Expand All @@ -352,7 +352,7 @@ jobs:
strategy_branch: "${{ env.distinguishing_name }}"

- name: Set s3 sts persistent storage variables for Windows
if: ${{ env.real_tests_enabled }} != 'no' && matrix.os == 'windows'
if: ${{ env.real_tests_enabled != 'no' && matrix.os == 'windows' }}
uses: ./.github/actions/set_s3_sts_persistent_storage_env_vars
with:
aws_access_key: "${{ secrets.AWS_S3_ACCESS_KEY }}"
Expand All @@ -378,8 +378,9 @@ jobs:

# Fallback if the clean up at test fixutre tear down fails due to crash or etc
- name: Remove AWS testing account and credentials
if: always() && inputs.persistent_storage == 'true' && matrix.os == 'windows'
if: ${{ always() && env.real_tests_enabled != 'no' && matrix.os == 'windows' }}
run: |
echo "env.real_tests_enabled: [${{ env.real_tests_enabled }}]"
Copy link
Collaborator

@G-D-Petrov G-D-Petrov Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really needed as GH already prints the env vars that are used in a given step

python -c "
from arcticdb.storage_fixtures.s3 import real_s3_sts_clean_up
real_s3_sts_clean_up('${ARCTICDB_REAL_S3_STS_TEST_USERNAME}', '${ARCTICDB_REAL_S3_STS_TEST_ROLE}', '${ARCTICDB_REAL_S3_STS_TEST_POLICY_NAME}')
Expand Down
Loading