-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [AnalysisWizard] Language discovery changes #1951
✨ [AnalysisWizard] Language discovery changes #1951
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1951 +/- ##
==========================================
+ Coverage 39.20% 42.73% +3.53%
==========================================
Files 146 166 +20
Lines 4857 5258 +401
Branches 1164 1299 +135
==========================================
+ Hits 1904 2247 +343
- Misses 2939 2995 +56
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6c07c23
to
8d20b5a
Compare
8d20b5a
to
9a17217
Compare
client/src/app/pages/applications/analysis-wizard/set-targets.tsx
Outdated
Show resolved
Hide resolved
5111586
to
582c39e
Compare
e2e ui testing is failing: https://github.com/konveyor/tackle2-ui/actions/runs/9504942845/job/26198861030?pr=1951#step:10:1822 |
f30ac9a
to
b833c10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First look makes sense, but there is an inconsistency with the Target.provider field.
client/src/app/api/models.ts
Outdated
@@ -425,7 +425,7 @@ export interface Target { | |||
labels?: TargetLabel[]; | |||
image?: RulesetImage; | |||
ruleset: Ruleset; | |||
provider?: string; | |||
provider?: string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The provider is still a single string on the hub side: https://github.com/konveyor/tackle2-hub/blob/main/api/target.go#L242
226a575
to
4cc1172
Compare
Move to simple multi select menu in set targets step Drive target selection options from targets list Address missing checkbox on deselect Add provider to target card header Signed-off-by: Ian Bolton <[email protected]>
4cc1172
to
d26381d
Compare
Signed-off-by: Ian Bolton <[email protected]>
b9bf667
to
1e4f9ec
Compare
Fixed. |
client/src/app/pages/applications/analysis-wizard/set-targets.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've found one bug during smoke tests:
- filter by "Java" and select some cards
- go back in the wizard
- enter the target selection step again: filter is missing, cards cannot be de-selected
Signed-off-by: Ian Bolton <[email protected]>
ef73291
to
765b264
Compare
Looks like this bug shows up as a result of introducing checkboxes for unselected cards:
I'd like to fix this in another issue if possible. Need to investigate the PF component. Reverted the change for now & #1252 will remain open. |
@ibolton336
|
Fixed. |
Resolves #1950
UI Tests PR: 1136
Needs: konveyor/tackle-ui-tests#1136
Includes: