-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix target card behavior and rendering #2025
Conversation
Resolves: konveyor#2022 Resolves: konveyor#2010 Resolves: konveyor#1981 Resolves: https://issues.redhat.com/browse/MTA-3094 Target card behavior and rendering on the target selection step of the analysis wizard and on the custom migrations target page have been updated: - All of the card contents render inside the card itself (konveyor#1981 / MTA-3094) - When changing the specific label selection for a target, the card selection will not changes (konveyor#2010) - The target label select now sorts the labels in numeric natural sort descending order. `OpenJDK 21` will be initially selected and appear above `OpenJDK 17` in the select list. (konveyor#2022) - Layouts used on the card have been refactored to use base layouts instead of the `EmptyState` component - The target label select box has been updated to the current `SimpleSelectBasic` component for current PF5 alignment - When card selection is enabled (on the target selection step of the analysis wizard), the selection checkbox is always displayed and the normal `Card` hover styles have been disabled. Some refactoring on the `SetTargets` component used by the analysis wizard have been made to simplify rendering code. Signed-off-by: Scott J Dickerson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2025 +/- ##
==========================================
+ Coverage 39.20% 42.14% +2.94%
==========================================
Files 146 171 +25
Lines 4857 5505 +648
Branches 1164 1376 +212
==========================================
+ Hits 1904 2320 +416
- Misses 2939 3069 +130
- Partials 14 116 +102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still seeing the bug outlined here when navigating back in the wizard.
#1951 (review)
Screen.Recording.2024-07-24.at.10.45.04.AM.mov
More info here: #1252 (comment)
Signed-off-by: Scott J Dickerson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job identifying that bug.
Resolves: #2022
Resolves: #2010
Resolves: #1981
Resolves: #1252
Resolves: https://issues.redhat.com/browse/MTA-3094
Target card behavior and rendering on the target selection step of the analysis wizard and on the custom migrations target page have been updated:
OpenJDK 21
will be initially selected and appear aboveOpenJDK 17
in the select list. ([BUG] Make OpenJDK 21 the default rather than 11 #2022)EmptyState
componentSimpleSelectBasic
component for current PF5 alignmentCard
hover styles have been disabled.CardHeader.selectableActions
have been aligned to current PF and the click handler moved toonChange
instead of theCard.onClick
. TheselectableActionId
needs to be unique on the page for the select handling to work properly.Some refactoring on the
SetTargets
component used by the analysis wizard have been made to simplify rendering code.