Skip to content

Commit 1e4f9ec

Browse files
committed
Fix broken QE selector
Signed-off-by: Ian Bolton <[email protected]>
1 parent 22d308b commit 1e4f9ec

File tree

5 files changed

+8
-5
lines changed

5 files changed

+8
-5
lines changed

client/src/app/api/models.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ export interface Target {
456456
labels?: TargetLabel[];
457457
image?: RulesetImage;
458458
ruleset: Ruleset;
459-
provider?: string[];
459+
provider?: string;
460460
}
461461

462462
export interface Metadata {

client/src/app/components/SimpleSelectCheckbox.tsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,12 @@ export const SimpleSelectCheckbox: React.FC<ISimpleSelectBasicProps> = ({
9393
onOpenChange={setIsOpen}
9494
toggle={(toggleref: React.Ref<MenuToggleElement>) => (
9595
<MenuToggle
96+
aria-label={toggleAriaLabel}
97+
id={toggleId}
9698
ref={toggleref}
9799
onClick={onToggleClick}
98100
style={{ width: width && width + "px" }}
99101
isExpanded={isOpen}
100-
id={toggleId}
101102
>
102103
<span className={spacing.mrSm}>{placeholderText}</span>
103104
{selectedItems.length > 0 && (
@@ -110,6 +111,7 @@ export const SimpleSelectCheckbox: React.FC<ISimpleSelectBasicProps> = ({
110111
<SelectList>
111112
{selectOptions.map((option, index) => (
112113
<SelectOption
114+
id={`checkbox-for-${option.value}`}
113115
hasCheckbox
114116
key={option.value}
115117
isFocused={index === 0}

client/src/app/components/target-card/target-card.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -110,14 +110,15 @@ export const TargetCard: React.FC<TargetCardProps> = ({
110110

111111
return (
112112
<Card
113+
id={`target-card-${target.name.replace(/\s/g, "-")}`}
113114
onClick={handleCardClick}
114115
isSelectable
115116
isSelected={isCardSelected}
116117
className="pf-v5-l-stack pf-v5-l-stack__item pf-m-fill"
117118
>
118119
<CardHeader
119120
selectableActions={{
120-
selectableActionId: "" + target.id,
121+
selectableActionId: "target-name-" + target.name,
121122
selectableActionAriaLabelledby: `${target.name}-selectable-action-label`,
122123
isChecked: isCardSelected,
123124
}}

client/src/app/pages/applications/analysis-wizard/set-targets.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ export const SetTargets: React.FC<SetTargetsProps> = ({ applications }) => {
184184
onChange={(selection) => {
185185
setProvider(selection as string[]);
186186
}}
187-
toggleId="language-select-toggle"
187+
toggleId="action-select-toggle"
188188
/>
189189
{values.selectedTargets.length === 0 &&
190190
values.customRulesFiles.length === 0 &&

client/src/app/pages/migration-targets/components/custom-target-form.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ export const CustomTargetForm: React.FC<CustomTargetFormProps> = ({
307307
},
308308
}),
309309
},
310-
provider: [providerType] || ["Java"],
310+
provider: providerType || "Java",
311311
};
312312

313313
if (target) {

0 commit comments

Comments
 (0)