Move discussion-rendering into DCR #8057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kage import Co-authored-by: Jamie Byers <[email protected]>
|
Size Change: -20.1 kB (-3%) Total Size: 590 kB
ℹ️ View Unchanged
|
Georges-GNM
changed the title
refactor `decideShowMoreText` to take a parameter of the remaining comment count. This avoids handling undefined values
chance this has made things worse!!
ignore the correct line
georgeblahblah
changed the title
|
Great work!! Very happy to see this. Because this is moving into a new repo I just wanted to link to this issue to preserve some discoverability: #8243 The issue itself suggests pushing logic down into The relevance of this issue is that bringing it into DCR will hopefully make it easier to fix a couple of long-standing bugs with loading comments, if and when someone has the time to do so. The issue is not written super clearly tbh (which I take full responsibility for!) But I'll try to clarify it when I get the chance, and in the meantime this will hopefully at least provide a pointer if anyone does look at picking the bugs up. |
DanielCliftonGuardian
approved these changes
Jul 3, 2023
georgeblahblah
approved these changes
Jul 3, 2023
georgeblahblah
added a commit
that referenced
this pull request
Aug 11, 2023
`discussion-rendering` became part of DCR in #8057. At the time, we did not want to make too many changes at once by moving files into DCR's folder structure, so we put everything under the `discussion-rendering` directory. This change moves files out of `discussion-rendering` into the equivalent places, and deletes the `discussion-rendering` directory.
This was referenced Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored by: George Buckingham [email protected]
Co-authored by: Jamie Byers [email protected]
What does this change?
This brings the discussion-rendering package into DCR, simply by copying the files from the
srcfolder in discussion-rendering and pasting them into adiscussion-renderingfolder in DCR.No changes to any of the components or files have been made, other than what was necessary to satisfy the stricter linting rules that exist in DCR and were absent in discussion-rendering; the intention was to simply transport the project over into the world of DCR, rather than carry out the required and significant refactoring to make discussion-rendering fit in it alongside the rest of the elements in DCR. In some cases this has meant outright ignoring the linting errors; todo comments have been added to help guide follow-up refactoring work.
Why?
Closes issue #7590. As per its description: "now that we're no longer going to be using discussion-rendering in AR (see #7366), the only project that's ever likely to depend on it is DCR. We could save ourselves the overhead of maintaining a separate library by pulling all the code into the DCR codebase and deprecating discussion-rendering."
Aside from making sense from an architectural sense, this also enables us to more easily progress the Okta migration work, which requires some changes to discussion-rendering. Moving it directly into DCR means we can directly use the prior IdentityAuth work we've set up in DCR and avoids us needing to publish an update to the discussion-rendering package.
Other tasks once this is merged