Code

Move discussion-rendering into DCR#8057

Code

Merged

Georges-GNM merged 52 commits intomainguardian/dotcom-rendering:mainfrom gl/move-discussion-rendering-into-dcrguardian/dotcom-rendering:gl/move-discussion-rendering-into-dcrCopy head branch name to clipboardJul 3, 2023

+10,882-9,354

Commits

Commits on Jun 27, 2023

• initial work on moving discussion-rendering into dcr and removing package import

  Show description for e3e20a7
  

  Georges-GNM

  and

  Jamie Byers

  committed
  e3e20a7

  Copy full SHA for e3e20a7

• fix(lint): rename variable to fix shadowing

  georgeblahblah

  committed
  ea7b3bc

  Copy full SHA for ea7b3bc

• lint fixes for CommentForm

  georgeblahblah

  committed
  796efc1

  Copy full SHA for 796efc1

• fix(lint): lint fixes for FirstCommentWelcome

  georgeblahblah

  committed
  0d980a7

  Copy full SHA for 0d980a7

• fix(lint): Lint fixes for PillarButton

  georgeblahblah

  committed
  cca2293

  Copy full SHA for cca2293

• fix(lint): fix CommentContainer

  Show description for 212e558
  georgeblahblah

  committed
  212e558

  Copy full SHA for 212e558

• Lint formatting fix

  georgeblahblah

  committed
  e56c60b

  Copy full SHA for e56c60b

• refactor useInterval by specifying callback function shape

  georgeblahblah

  committed
  f745e23

  Copy full SHA for f745e23

• rm unused reducer module

  georgeblahblah

  committed
  46db916

  Copy full SHA for 46db916

• specify return type of joinUrl and use isNonNullable

  georgeblahblah

  committed
  3441df8

  Copy full SHA for 3441df8

• refactor joinUrl to use startsWith/endsWith

  georgeblahblah

  committed
  e9a7682

  Copy full SHA for e9a7682

• create narrower type for setCurrentPage prop

  georgeblahblah

  committed
  0235cf1

  Copy full SHA for 0235cf1

• lint fixes for AbuseReportForm

  georgeblahblah

  committed
  8c69c56

  Copy full SHA for 8c69c56

• more lint fixes :)

  georgeblahblah

  committed
  cf9e81e

  Copy full SHA for cf9e81e

• AbuseReportForm lint formatting

  georgeblahblah

  committed
  66f6a6d

  Copy full SHA for 66f6a6d

• Simplify AbuseReportForm test

  georgeblahblah

  committed
  a560711

  Copy full SHA for a560711

• lint fix for CommentContainer.test.tsx

  georgeblahblah

  committed
  a766904

  Copy full SHA for a766904

• lint fixes for Comment

  georgeblahblah

  committed
  b0fe19d

  Copy full SHA for b0fe19d

• more lint fixes

  georgeblahblah

  committed
  c2fa809

  Copy full SHA for c2fa809

• refactor dateFormatter to use Intl.DateTimeFormat

  georgeblahblah

  committed
  13e9a5a

  Copy full SHA for 13e9a5a

Commits on Jun 28, 2023

• delete joinUrl module in favour of @guardian/libs implementation

  georgeblahblah

  committed
  570049e

  Copy full SHA for 570049e

• refactor to use jest over vitest

  georgeblahblah

  committed
  25f8b23

  Copy full SHA for 25f8b23

• refactor arguments to joinUrl

  georgeblahblah

  committed
  ac3e687

  Copy full SHA for ac3e687

• refactor objAsParams to be more typesafe

  Show description for da46673
  georgeblahblah

  committed
  da46673

  Copy full SHA for da46673

• ignore unsafe member access errors

  Show description for f3c8730
  georgeblahblah

  committed
  f3c8730

  Copy full SHA for f3c8730

• more lint fixes

  georgeblahblah

  committed
  991e3d8

  Copy full SHA for 991e3d8

• use type React.ReactNode for children props

  georgeblahblah

  committed
  4aabb73

  Copy full SHA for 4aabb73

• stylelint fixes

  georgeblahblah

  committed
  e7cedaa

  Copy full SHA for e7cedaa

• prettier fixes

  georgeblahblah

  committed
  963ab83

  Copy full SHA for 963ab83

• Revert "refactor dateFormatter to use Intl.DateTimeFormat"

  Show description for 9ea918d
  georgeblahblah

  committed
  9ea918d

  Copy full SHA for 9ea918d

• Revert "refactor objAsParams to be more typesafe"

  Show description for 8e93fbd
  georgeblahblah

  committed
  8e93fbd

  Copy full SHA for 8e93fbd

• add comments about why we ignore eslint errors

  georgeblahblah

  committed
  34a5adc

  Copy full SHA for 34a5adc

• remove test prop

  georgeblahblah

  committed
  a467408

  Copy full SHA for a467408

• refactor test to check request body for categoryId

  georgeblahblah

  committed
  a0a60a9

  Copy full SHA for a0a60a9

• return undefined to silence empty function warning

  georgeblahblah

  committed
  9f5dfe6

  Copy full SHA for 9f5dfe6

• refactor month name lookup

  georgeblahblah

  committed
  cabb8c0

  Copy full SHA for cabb8c0

• refactor disabled dropdown logic

  georgeblahblah

  committed
  caf58b8

  Copy full SHA for caf58b8

• add comment explaining we don't have a Source monospace font

  georgeblahblah

  committed
  9733f15

  Copy full SHA for 9733f15

• fix logic for muting users

  georgeblahblah

  committed
  802fd68

  Copy full SHA for 802fd68

• return undefined instead of nothing

  georgeblahblah

  committed
  e7c358b

  Copy full SHA for e7c358b

• handle 0 and NaN widths as well

  georgeblahblah

  committed
  c9a7303

  Copy full SHA for c9a7303

• check NaN and 0

  georgeblahblah

  committed
  36e078c

  Copy full SHA for 36e078c

• add comment explaining stylelint rule squash

  georgeblahblah

  committed
  2ccda79

  Copy full SHA for 2ccda79

• add TODO to implement error handling

  georgeblahblah

  committed
  2cb41c2

  Copy full SHA for 2cb41c2

• fix indentation

  georgeblahblah

  committed
  62195d4

  Copy full SHA for 62195d4

• put prettier last in eslint config

  georgeblahblah

  committed
  1485839

  Copy full SHA for 1485839

• Array.prototype.find => Array.prototype.some

  georgeblahblah

  committed
  0a4b2b4

  Copy full SHA for 0a4b2b4

• disable eslint formatting rules

  georgeblahblah

  committed
  77470af

  Copy full SHA for 77470af

Commits on Jun 29, 2023

• set discussion fixtures

  georgeblahblah

  committed
  f9e8cc6

  Copy full SHA for f9e8cc6

• use mockRESTCalls for all mocks

  georgeblahblah

  committed
  c946a34

  Copy full SHA for c946a34

• replace discussion fixture with a shorter one

  georgeblahblah

  committed
  237656d

  Copy full SHA for 237656d

Commits on Jun 30, 2023

• updated timestamp stories to an appropriate time relative to dcr timestamp

  Georges-GNM

  committed
  78a5f83

  Copy full SHA for 78a5f83