Migrate Discussion To decidePalette
#8576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 656 kB ℹ️ View Unchanged
|
sophie-macmillan
approved these changes
Aug 16, 2023
georgeblahblah
force-pushed
the
gb/discussion-palette
branch
from
c976082 to
31d3159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved
discussion-renderinginto DCR in #8057. We decided to minimise the number of changes during the move. Originally, Discussion Rendering components decided colours based on a pillar value. This differs to DCR, which uses the article's format to decide colours, via thedecidePalettefunction.This change migrates the Discussion Rendering components to use the same palette lookup mechanism as DCR's components.
In many cases, Discussion Rendering components use the article format's theme to look up a colour for multiple different uses. Instead of capturing each use in the
Palettetype, I've included it as a single key underdiscussionGeneric.