Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit dependency on plugin library #124

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

mjcarroll
Copy link
Contributor

Required on Windows, particularly for Ninja generator, which aggressively parallelizes.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #124 (dbddcb1) into gz-plugin2 (0e30b52) will not change coverage.
The diff coverage is n/a.

❗ Current head dbddcb1 differs from pull request most recent head 06cf99c. Consider uploading reports for the commit 06cf99c to get more accurate results

@@             Coverage Diff             @@
##           gz-plugin2     #124   +/-   ##
===========================================
  Coverage       98.26%   98.26%           
===========================================
  Files              23       23           
  Lines             748      748           
===========================================
  Hits              735      735           
  Misses             13       13           

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@ahcorde ahcorde merged commit b1f379d into gz-plugin2 Sep 14, 2023
8 checks passed
@ahcorde ahcorde deleted the mjcarroll/explicit_dependency branch September 14, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants