Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit dependency on plugin library #124

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Add explicit dependency on plugin library #124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f92eae0
Add explicit dependency on plugin library
mjcarroll Sep 14, 2023
06cf99c
Merge branch 'gz-plugin2' into mjcarroll/explicit_dependency
ahcorde Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/integration/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
# linking generator expressions as described here:
# https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html#genex:LINK_LIBRARY
target_link_libraries(INTEGRATION_static_plugins -WHOLEARCHIVE:$<TARGET_FILE:GzDummyStaticPlugin>)
# The whole-archive invocation doesn't correctly compute dependencies,
# so explicitly require the plugin before the test can build.
add_dependencies(INTEGRATION_static_plugins GzDummyStaticPlugin)
else()
target_link_libraries(INTEGRATION_static_plugins
$<$<CXX_COMPILER_ID:GNU>:-Wl,--whole-archive>
Expand Down