Skip to content

Commit b1f379d

Browse files
mjcarrollahcorde
andauthored
Add explicit dependency on plugin library (#124)
Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
1 parent 0e30b52 commit b1f379d

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

test/integration/CMakeLists.txt

+3
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
5555
# linking generator expressions as described here:
5656
# https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html#genex:LINK_LIBRARY
5757
target_link_libraries(INTEGRATION_static_plugins -WHOLEARCHIVE:$<TARGET_FILE:GzDummyStaticPlugin>)
58+
# The whole-archive invocation doesn't correctly compute dependencies,
59+
# so explicitly require the plugin before the test can build.
60+
add_dependencies(INTEGRATION_static_plugins GzDummyStaticPlugin)
5861
else()
5962
target_link_libraries(INTEGRATION_static_plugins
6063
$<$<CXX_COMPILER_ID:GNU>:-Wl,--whole-archive>

0 commit comments

Comments
 (0)