Hey @ivanvc, do you need some help here? I could take on a few items on the list if you want me to. Just let me know which are the preferred ones.
Thank you

Hi @ghouscht, thanks for offering your help with this task. Although it's unassigned (because I can't assign it to people outside of the etcd-io organization if they haven't participated in the issue), @mmorel-35 is doing it.

Therefore, I'm going to redirect the question. @mmorel-35, is there anything that @ghouscht could do to help with this task? Thanks.

We actually have two open PR for this linter so until they are merged you can start with the error-is-as or formatter with formatter.require-f-funcs option enabled. Keep your PR as draft until one of them is merged so the number of opened PR stay narrowed concerning testifylint.

You can configure it with https://golangci-lint.run/usage/linters/#testifylint

Golangci lint can not fix it with --fix. You can use testifylint with -fix to start fixing it then review the changes to see if everthing works correctly.

Thank you for the response @mmorel-35, I found some time today and opened two PRs for the error-is-as and formatter rules:

• fix: enable error-is-as rule from testifylint #18740
• fix: enable formatter rule from testifylint #18741

I also tagged you on the PRs (sorry for the spam 🙂).

/assign @mmorel-35 @ghouscht

Just curious - we should compare the make verify runtime before enabling these checks and now to make sure we aren't increasing test runtimes too significantly.

@mmorel-35 - As you have enabled these linter rules have you noticed any meaningful increase in test runtimes in CI or locally?

I haven't noticed any significant increase. What make you think there could be regarding the nature of changes that has been done yet ?

Running make verify-lint yields the following runtime on my machine

with a clean golangci-lint cache:

• with testifylint 21.941s
• without 20.632s

with golangci-lint cache present:

• with testifylint 4.926s
• without 4.947s

I'd say that is neglible 🙂