Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable empty and len rules from testifylint #18712

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

mmorel-35
Copy link
Contributor

This fixes empty and len rules from testifylint.

@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmorel-35
Copy link
Contributor Author

/assign @serathius

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (5e238a0) to head (a82fd2d).

Current head a82fd2d differs from pull request most recent head e06fb81

Please upload reports for the commit e06fb81 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18712      +/-   ##
==========================================
- Coverage   68.80%   68.76%   -0.04%     
==========================================
  Files         420      420              
  Lines       35494    35494              
==========================================
- Hits        24423    24409      -14     
- Misses       9646     9664      +18     
+ Partials     1425     1421       -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e238a0...e06fb81. Read the comment docs.

@ahrtr
Copy link
Member

ahrtr commented Oct 10, 2024

/ok-to-test

@mmorel-35
Copy link
Contributor Author

@ahrtr ,
I rebased, that shall be ready for merging after the tests are passed

@mmorel-35
Copy link
Contributor Author

/test pull-etcd-integration-1-cpu-amd64

@mmorel-35
Copy link
Contributor Author

/assign @jmhbnz

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @mmorel-35

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 133918e into etcd-io:main Oct 10, 2024
37 checks passed
@mmorel-35 mmorel-35 deleted the testifylint/empty+len branch October 11, 2024 11:46
@ivanvc ivanvc mentioned this pull request Oct 11, 2024
19 tasks
@ivanvc
Copy link
Member

ivanvc commented Oct 11, 2024

Link to #18719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants