deprecate testutil/assert.go

[mmorel-35]

This deprecate client/pkg/testutil/assert.go methods.

[k8s-ci-robot]

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mmorel-35]

/cc @ivanvc
/cc @jmhbnz
/assign @wenjiaswe

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.73%. Comparing base (f0187c3) to head (3498a18).

❗ Current head 3498a18 differs from pull request most recent head 8c29d78

Please upload reports for the commit 8c29d78 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18717      +/-   ##
==========================================
+ Coverage   68.72%   68.73%   +0.01%     
==========================================
  Files         420      420              
  Lines       35494    35494              
==========================================
+ Hits        24394    24398       +4     
+ Misses       9676     9668       -8     
- Partials     1424     1428       +4     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0187c3...8c29d78. Read the comment docs.

[ivanvc]

Thanks for doing this follow-up, @mmorel-35!

This seems reasonable, as after Matthieu did #18689 and #18686, these functions are no longer used. I initially suggested removing them, but he pointed out they could be used externally (which makes sense as they're exported functions).

@ahrtr, @serathius, WDYT?

[jmhbnz]

/ok-to-test

[mmorel-35]

/test pull-etcd-e2e-386

[ivanvc]

Link to #18719

[jmhbnz]

LGTM - Thanks @mmorel-35

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,jmhbnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment