-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable float-compare rule from testifylint #18776
Conversation
Signed-off-by: Matthieu MOREL <[email protected]>
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 32 files with indirect coverage changes @@ Coverage Diff @@
## main #18776 +/- ##
==========================================
+ Coverage 68.75% 68.80% +0.04%
==========================================
Files 420 420
Lines 35508 35508
==========================================
+ Hits 24415 24431 +16
+ Misses 9657 9654 -3
+ Partials 1436 1423 -13 Continue to review full report in Codecov by Sentry.
|
/assign @spzala |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmorel-35, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This fixes float-compare rule from testifylint.
Related to #18719