Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable float-compare rule from testifylint #18776

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 24, 2024

This fixes float-compare rule from testifylint.

Related to #18719

@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (2ea1fb5) to head (906fdee).

Current head 906fdee differs from pull request most recent head 4c8a41c

Please upload reports for the commit 4c8a41c to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 32 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18776      +/-   ##
==========================================
+ Coverage   68.75%   68.80%   +0.04%     
==========================================
  Files         420      420              
  Lines       35508    35508              
==========================================
+ Hits        24415    24431      +16     
+ Misses       9657     9654       -3     
+ Partials     1436     1423      -13     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea1fb5...4c8a41c. Read the comment docs.

@mmorel-35
Copy link
Contributor Author

/assign @spzala

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmorel-35, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit aae197c into etcd-io:main Oct 24, 2024
18 checks passed
@mmorel-35 mmorel-35 deleted the testifylint/float-compare branch October 24, 2024 08:58
@ivanvc ivanvc mentioned this pull request Oct 29, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants