Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add error checking for some commonly observed problems, plus test cases #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ctb
Copy link
Member

@ctb ctb commented Mar 21, 2019

check for broken yaml config (no 'samples' entry) and badly formatted 'samples.tsv' (#41 is relevant).

These are common errors happening in GGG 201(b).

@ctb
Copy link
Member Author

ctb commented Mar 21, 2019

@bluegenes some guidance requested - what's the right test file to add the tests to? (see tests/test_files/ for the two yaml config files I want to run as part of the tests).

@ctb
Copy link
Member Author

ctb commented Mar 22, 2019

Looks like #116 addresses this too. Will have to see if there are automated tests checking the behavior; if there are, we can close this!

bluegenes added a commit that referenced this pull request Mar 22, 2019
@bluegenes
Copy link
Member

grabbed the examples and added tests for them in tests/test_inputs.py. Suggest closing this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants