Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing -r to pip install call. #922

Merged
merged 1 commit into from
Jul 11, 2020

Conversation

hzeller
Copy link
Collaborator

@hzeller hzeller commented Jul 10, 2020

Issue #913

Signed-off-by: Henner Zeller [email protected]

Issue #913

Signed-off-by: Henner Zeller <[email protected]>
@hzeller hzeller requested a review from tgorochowik July 10, 2020 23:12
Copy link
Collaborator

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM!

I think maybe the README is wrong however? Shouldn't it be talking about the conda stuff?

@hzeller
Copy link
Collaborator Author

hzeller commented Jul 10, 2020

The README is still targeting the regular local building, which is what someone using the tests is more interested in.

The conda stuff we mostly use for CI to get all the things; but it might be also useful to document, I agree (but not this change).

@mithro
Copy link
Collaborator

mithro commented Jul 10, 2020

SGTM!

@hzeller hzeller merged commit eaaee14 into chipsalliance:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants