Dilithium driver #1624
Draft
Dilithium driver #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurHeymans
force-pushed
the
dilithium_driver
branch
from
b2e9342
to
6ee62b6
Compare
ArthurHeymans
force-pushed
the
dilithium_driver
branch
from
6ee62b6
to
be74e36
Compare
ArthurHeymans
requested review from
mhatrevi,
ajisaxena,
vsonims,
korran,
JohnTraverAmd and
rusty1968
as code owners
ArthurHeymans
force-pushed
the
dilithium_driver
branch
from
be74e36
to
2a48721
Compare
Signed-off-by: Arthur Heymans <[email protected]>
ArthurHeymans
force-pushed
the
dilithium_driver
branch
from
2a48721
to
c20c928
Compare
This adds both a driver and some unit tests. Some TODOs are left in the driver as it is intended to hook this peripheral to the keyvault in the future. Signed-off-by: Arthur Heymans <[email protected]>
ArthurHeymans
force-pushed
the
dilithium_driver
branch
from
c20c928
to
a21c5ea
Compare
| let secret_key = Array4x1224::read_from_reg(ml_dsa87.secret_key_out()); | ||
|
|
||
| let public_key = Array4x648::read_from_reg(ml_dsa87.public_key()); | ||
|
|
There was a problem hiding this comment.
I ran into an issue when enabling on Adam's Bridge RTL where the the sign was not completing. The feedback I got from MSFT is that the zeroize should happen between each operation. For enabling I added a call to zeroize here before the PCT.
| ml_dsa87.ctrl().write(|w| w.ctrl(|w| w.signing())); | ||
|
|
||
| // Wait for hardware ready | ||
| wait::until(|| ml_dsa87.status().read().ready()); |
There was a problem hiding this comment.
I think you mean to wait for valid here, not ready.
| ml_dsa87.ctrl().write(|w| w.ctrl(|w| w.verifying())); | ||
|
|
||
| // Wait for hardware ready | ||
| wait::until(|| ml_dsa87.status().read().ready()); |
There was a problem hiding this comment.
I think you mean to wait for valid here, not ready.
| wait::until(|| ml_dsa87.status().read().ready()); | ||
|
|
||
| let result = Array4x16::read_from_reg(ml_dsa87.verification_result()); | ||
| // TODO currently emulator returns 1 on each word for success. Update when behavior is fleshed out |
There was a problem hiding this comment.
RDL says that it should match the first part of the signature: https://github.com/chipsalliance/adams-bridge/blob/main/src/mldsa_top/rtl/mldsa_reg.rdl#L168
I have not been able to get that with the RTL though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add preliminary driver support for the dilithium peripheral.
The code follows the ecc384 driver structure.