Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] MLDSA-87 driver interface #1717

Merged
merged 1 commit into from
Oct 15, 2024
Merged

[feat] MLDSA-87 driver interface #1717

merged 1 commit into from
Oct 15, 2024

Conversation

mhatrevi
Copy link
Collaborator

This change contains the interface for the MLDSA-87 driver.

@mhatrevi
[feat] MLDSA-87 driver interface.
0966fd5 
This change contains the interface for the MLDSA-87 driver.
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

CLA Not Signed

ArthurHeymans
ArthurHeymans approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@ArthurHeymans ArthurHeymans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea to pull in code from #1624 ?

swenson
swenson approved these changes Oct 14, 2024
View reviewed changes
Copy link

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhatrevi
Copy link
Collaborator Author

Is the idea to pull in code from #1624 ?

Yes; this change is to unblock the DICE derivation changes. The driver implementation will happen when the Dilithium Key Vault hw integration is available.

@mhatrevi mhatrevi merged commit dfabd74 into main-2.x Oct 15, 2024
9 of 11 checks passed
@mhatrevi mhatrevi added the Caliptra v2.0 Items to be considered for v2.0 Release label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swenson swenson swenson approved these changes

@ArthurHeymans ArthurHeymans ArthurHeymans approved these changes

@ajisaxena ajisaxena Awaiting requested review from ajisaxena ajisaxena is a code owner

@vsonims vsonims Awaiting requested review from vsonims vsonims is a code owner

@korran korran Awaiting requested review from korran korran is a code owner

@JohnTraverAmd JohnTraverAmd Awaiting requested review from JohnTraverAmd JohnTraverAmd is a code owner

@rusty1968 rusty1968 Awaiting requested review from rusty1968 rusty1968 is a code owner

Assignees
No one assigned
Labels
Caliptra v2.0 Items to be considered for v2.0 Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhatrevi @swenson @ArthurHeymans