Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uhdm libs out of own folder, use soversion (fixes #992) #1002

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Remove uhdm libs out of own folder, use soversion (fixes #992) #1002

merged 1 commit into from
Aug 28, 2023

Conversation

timkpaine
Copy link
Collaborator

@timkpaine timkpaine commented Aug 17, 2023

This PR does two things:

  • instead of installing into lib/uhdm/, we will install into lib. This is the normal method, installing into lib/uhdm/ has caused problems on both conda and homebrew, and is sure to continue to cause headaches
  • we use SOVERSION so that lib/libuhdm.so is now a symlink, and we install a versioned lib/libuhdm.so.<major>.<minor>

Fixes #992

(I will do a similar PR for Surelog)


-- Installing: /tmp/uhdm-install/lib/libuhdm.so.1.71
-- Installing: /tmp/uhdm-install/lib/libuhdm.so

@timkpaine timkpaine requested a review from hzeller August 17, 2023 15:16
@timkpaine timkpaine marked this pull request as ready for review August 17, 2023 15:16
@alaindargelas
Copy link
Collaborator

@hzeller please review early next week.

@mithro
Copy link
Collaborator

mithro commented Aug 18, 2023

@hzeller is out of office until 28th August

@timkpaine
Copy link
Collaborator Author

there's no explicit rush (other than the desire to not leave PRs open for too long).

@hzeller hzeller merged commit d9f18bf into chipsalliance:master Aug 28, 2023
6 checks passed
@timkpaine timkpaine deleted the tkp/install branch August 28, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libuhdm.so should have a numbered SONAME
4 participants