Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uhdm 1.74 (new formula) #139476

Merged
merged 2 commits into from
Sep 3, 2023
Merged

uhdm 1.74 (new formula) #139476

merged 2 commits into from
Sep 3, 2023

Conversation

timkpaine
Copy link
Contributor

@timkpaine timkpaine commented Aug 14, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Aug 14, 2023
@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@timkpaine timkpaine marked this pull request as ready for review August 14, 2023 02:52
Formula/uhdm.rb Outdated Show resolved Hide resolved
Formula/uhdm.rb Outdated Show resolved Hide resolved
Formula/uhdm.rb Outdated Show resolved Hide resolved
Formula/uhdm.rb Outdated Show resolved Hide resolved
@timkpaine
Copy link
Contributor Author

timkpaine commented Aug 14, 2023

Looks like I need to fix capnproto build (which incidentally is building static libraries)

/usr/bin/ld: /home/linuxbrew/.linuxbrew/lib/libkj.a(exception.c++.o): relocation R_X86_64_TPOFF32 against `_ZN2kj12_GLOBAL__N_1L19threadLocalCallbackE' can not be used when making a shared object; recompile with -fPIC

Formula/uhdm.rb Outdated Show resolved Hide resolved
@timkpaine
Copy link
Contributor Author

xref: chipsalliance/UHDM#1002

@timkpaine
Copy link
Contributor Author

ok sorry for the noise, all set for review (again)

Formula/u/uhdm.rb Outdated Show resolved Hide resolved
Formula/u/uhdm.rb Outdated Show resolved Hide resolved
Formula/u/uhdm.rb Outdated Show resolved Hide resolved
Formula/u/uhdm.rb Outdated Show resolved Hide resolved
Formula/u/uhdm.rb Outdated Show resolved Hide resolved
Formula/u/uhdm.rb Outdated Show resolved Hide resolved
@timkpaine timkpaine changed the title uhdm 1.71 (new formula) uhdm 1.74 (new formula) Sep 2, 2023
Formula/u/uhdm.rb Show resolved Hide resolved
Formula/u/uhdm.rb Show resolved Hide resolved
@MikeMcQuaid
Copy link
Member

Thanks so much for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock, @timkpaine!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 3, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 3, 2023
Merged via the queue into Homebrew:master with commit f61621f Sep 3, 2023
12 checks passed
@timkpaine
Copy link
Contributor Author

Thanks @MikeMcQuaid and apologies in advance for the flurry of PRs I'm about to open for the next few items 😅

@timkpaine timkpaine deleted the tkp/uhdm branch September 3, 2023 16:59
@timkpaine timkpaine mentioned this pull request Sep 7, 2023
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants