Configuration: Split options into global and per-module configuration

[RAOF]

This lets each module define its own options, without needing the option names to be unique across all modules.

Also organises the module-specific options into their own sections at the end of the help text.

[RAOF]

Aaargh. When did those tests break?

[RAOF]

Now with fewer conflicts 🤦‍♀️

[AlanGriffiths]

Generally, I like the approach and the result.

In addition to the naming tweaks and mircommon stanza, this breaks ABI for mirplatform and mirserver

[AlanGriffiths]

Oops! The "Symbols Check" is failing because the symbols_map_generator isn't matching the corrected symbols.map...

INFO:__main__:symbols_map_generator is running in 'diff' mode
INFO:__main__:MIR_SYMBOLS_MAP_GENERATOR_CLANG_SO_PATH is /usr/lib/llvm-18/lib/libclang-18.so.1
INFO:__main__:MIR_SYMBOLS_MAP_GENERATOR_CLANG_LIBRARY_PATH is /usr/lib/llvm-18/lib
INFO:__main__:Symbols map generation is beginning for library=mir_common with version=2.18
INFO:__main__:Processing external headers directory: /home/runner/work/mir/mir/include/common
INFO:__main__:Processing internal headers directory: /home/runner/work/mir/mir/src/include/common
External Symbols Diff:

  New Symbols 🟢🟢🟢
    std::hash::operator*;
    typeinfo?for?std::hash;

  Deleted Symbols 🔻🔻🔻

Internal Symbols Diff:

gmake[3]: *** [src/common/CMakeFiles/check-mircommon-symbols-map.dir/build.make:70: src/common/CMakeFiles/check-mircommon-symbols-map] Error 1
gmake[2]: *** [CMakeFiles/Makefile2:3151: src/common/CMakeFiles/check-mircommon-symbols-map.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:3158: src/common/CMakeFiles/check-mircommon-symbols-map.dir/rule] Error 2
gmake: *** [Makefile:621: check-mircommon-symbols-map] Error 2
Error: Process completed with exit code 2.

...I guess it does need fixing after all

[tarek-y-ismail]

Oops! The "Symbols Check" is failing because the symbols_map_generator isn't matching the corrected symbols.map...

Hmm, that's weird. It seems that the code builds fine without them. I just thought I accidentally added them so I deleted them...

[AlanGriffiths]

Hmm, that's weird. It seems that the code builds fine without them

Nothing weird about it. The Check runs --target check-mircommon-symbols-map, which isn't part of all.

The problem is that the script wrongly expects the std::hash symbols

[AlanGriffiths]

Maybe the way forward is to inline the std::hash specialization (if it is inline it shouldn't be exporting symbols)

template<>
struct std::hash<mir::SharedLibrary::Handle>
{
    auto operator()(mir::SharedLibrary::Handle const& handle) const noexcept -> std::size_t
    {
// either
        return std::hash<void*>{}(handle.handle);
// or 
        return handle.hash(); // With a hash() implementation in `SharedLibrary::Handle`
    }
};

[AlanGriffiths]

@tarek-y-ismail you should be able to test the symbols check with

MIR_SYMBOLS_MAP_GENERATOR_CLANG_SO_PATH=/usr/lib/llvm-18/lib/libclang-18.so.1 MIR_SYMBOLS_MAP_GENERATOR_CLANG_LIBRARY_PATH=/usr/lib/llvm-18/lib\
ninja -C build  check-mircommon-symbols-map

[tarek-y-ismail]

you should be able to test the symbols check with

As I expected, the generator script still exports std::hash and the checking script still complains about it. Even though the project builds fine.

External Symbols Diff:

  New Symbols 🟢🟢🟢
    std::hash::operator*;
    typeinfo?for?std::hash;

  Deleted Symbols 🔻🔻🔻

Internal Symbols Diff:

[AlanGriffiths]

As I expected, the generator script still exports std::hash and the checking script still complains about it. Even though the project builds fine.

yes, the script is doing the wrong thing. Which wouldn't matter if we didn't rely on it for symbols checking