Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.19.0 #3686

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Release 2.19.0 #3686

merged 6 commits into from
Dec 3, 2024

Conversation

AlanGriffiths
Copy link
Collaborator

@AlanGriffiths AlanGriffiths commented Nov 28, 2024 •
edited by tarek-y-ismail
Loading

rc1

Test Plan

Platforms

24.04 24.10
gbm-kms @AlanGriffiths @AlanGriffiths
atomic-kms @AlanGriffiths @AlanGriffiths
eglstream-kms @tarek-y-ismail
eglstream-kms + gbm-kms hybrid @tarek-y-ismail
x11 @AlanGriffiths @AlanGriffiths
wayland @AlanGriffiths @AlanGriffiths
virtual @AlanGriffiths @AlanGriffiths

Console Providers

24.04 24.10
vt @AlanGriffiths @AlanGriffiths
logind @AlanGriffiths @AlanGriffiths
minimal @AlanGriffiths

Window Manager Examples

24.04 24.10
--window-manager=floating @AlanGriffiths @AlanGriffiths
--window-manager=tiling @AlanGriffiths
-kiosk @AlanGriffiths

@AlanGriffiths AlanGriffiths requested a review from a team as a code owner November 28, 2024 12:36
@tarek-y-ismail
Copy link
Contributor

gbm-kms:

  • I tested login providers with gbm-kms out of curiosity. Executing the command specified in the logind section just starts miral-app without asking me to login. Is this correct?
  • When testing the tiling window manager. After opening a terminal with CTRL+ALT+T, trying to open another one crashes the compositor. However, opening the second one through the first works fine?

eglstream-kms + gbm-kms:

@AlanGriffiths
Copy link
Collaborator Author

  • I tested login providers with gbm-kms out of curiosity. Executing the command specified in the logind section just starts miral-app without asking me to login. Is this correct?

Yes.

  • When testing the tiling window manager. After opening a terminal with CTRL+ALT+T, trying to open another one crashes the compositor. However, opening the second one through the first works fine?

I don't see this. Which terminal are you using?

@AlanGriffiths
Copy link
Collaborator Author 

* [nvidia app closing russian roulette #3672](https://github.com/canonical/mir/issues/3672) and [Resizing xwayland apps crashes xwayland on nvidia (mir 2.18) #3598](https://github.com/canonical/mir/issues/3598) still occur under the same circumstances

* `DRI_PRIME` doesn't actually change which GPU is used for rendering.

We're not expecting these to change in this release

@tarek-y-ismail
Copy link
Contributor

tarek-y-ismail commented Nov 29, 2024 •
edited
Loading

I don't see this. Which terminal are you using?

This happens with gnome-terminal, kgx, and xterm. But qterminal, weston-terminal don't crash the compositor.

@AlanGriffiths
Copy link
Collaborator Author

AlanGriffiths commented Nov 29, 2024 •
edited
Loading

I don't see this. Which terminal are you using?

This happens with gnome-terminal, kgx, and xterm. But qterminal, weston-terminal don't crash the compositor.

Just trying to figure out what we're doing differently.

I've used miral-app --window-manager tiling on mir:x11 (hosted by Miriway/beta) and mir:gbm-kms (on intel+evdi) on 24.04 and 24.10, I don't see this problem with gnome-terminal, kgx or qterminal.

@tarek-y-ismail
Copy link
Contributor

tarek-y-ismail commented Nov 29, 2024 •
edited
Loading

For me, I'm running miral-app through a VT with eglstream-kms and gbm-kms. Smells of more eglstream-kms trouble?

@AlanGriffiths
Copy link
Collaborator Author

Smells of more eglstream-kms trouble?

Maybe even the same trouble?

@AlanGriffiths
Copy link
Collaborator Author

I'm running miral-app through a VT with eglstream-kms and gbm-kms

Can you test with ppa:mir-team/release and confirm whether this is new or pre-existing?

@tarek-y-ismail
Copy link
Contributor

2.18.3, same thing. I took a look at the logs, and maybe I'm missing something while booting miral-app?

Failed to register: Unable to acquire bus name 'io.mirserver.Terminal'
Mir fatal error: Accessing value of unset optional
!!! Fatal signal received. Attempting cleanup, but deadlock may occur
Mir fatal error: Unsupported attempt to continue after a fatal signal: SIGABRT

(gnome-terminal-server:30947): GLib-GIO-CRITICAL **: 15:15:55.775: g_dbus_proxy_new: assertion 'G_IS_DBUS_CONNECTION (connection)' failed

(gnome-terminal-server:30947): GLib-GIO-CRITICAL **: 15:15:55.775: g_dbus_proxy_new: assertion 'G_IS_DBUS_CONNECTION (connection)' failed
Gdk-Message: 15:15:57.170: Error reading events from display: Connection reset by peer

@AlanGriffiths
Copy link
Collaborator Author

2.18.3, same thing.

Not a blocker then.

I took a look at the logs, and maybe I'm missing something while booting miral-app?

Some of the messages are from gnome terminal, and not relevant to the server crash. The relevant ones are:

Mir fatal error: Accessing value of unset optional
!!! Fatal signal received. Attempting cleanup, but deadlock may occur
Mir fatal error: Unsupported attempt to continue after a fatal signal: SIGABRT

Which indicates we have logic wrong somewhere which leads to an abuse of mir::optional_value. That should be easy to track down: build locally and reproduce. That should get a usable core. If not a breakpoint on fatal_error_abort() will do.

@AlanGriffiths
Copy link
Collaborator Author

Huh?! Now I can reproduce this crash (only on 2.19 though). Investigating...

@AlanGriffiths
Copy link
Collaborator Author

Huh?! Now I can reproduce this crash (only on 2.19 though). Investigating...

This is new with 2.19 (since #3623). It's here:

void TilingWindowManagerPolicy::clip_to_tile(miral::WindowSpecification& parameters, Rectangle const& tile)
{
    auto const displacement = parameters.top_left().value() - tile.top_left;

    auto width = std::min(tile.size.width.as_int()-displacement.dx.as_int(), parameters.size().value().width.as_int());
    auto height = std::min(tile.size.height.as_int()-displacement.dy.as_int(), parameters.size().value().height.as_int());

    parameters.size() = Size{width, height};
}

@AlanGriffiths AlanGriffiths mentioned this pull request Nov 29, 2024
Closed
@AlanGriffiths
Copy link
Collaborator Author

AlanGriffiths commented Dec 2, 2024 •
edited
Loading

rc2

Test Plan

Platforms

24.04 24.10
gbm-kms @AlanGriffiths
atomic-kms
eglstream-kms
eglstream-kms + gbm-kms hybrid
x11 @AlanGriffiths
wayland @AlanGriffiths
virtual @AlanGriffiths

Console Providers

24.04 24.10
vt
logind @AlanGriffiths
minimal @AlanGriffiths

Window Manager Examples

24.04 24.10
--window-manager=floating @AlanGriffiths
--window-manager=tiling @AlanGriffiths
-kiosk @AlanGriffiths

@Conan-Kudo
Copy link
Contributor

mirserver ABI bumped to 61

According to my builds of Mir in Fedora, the mirserver bump happened in 2.18.0, so this is unchanged between 2.18 and 2.19.

Saviq
Saviq reviewed Dec 3, 2024
View reviewed changes
debian/changelog Outdated Show resolved Hide resolved
Saviq
Saviq approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@Saviq Saviq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yups. Third time's…

@Saviq Saviq enabled auto-merge December 3, 2024 16:54
@Saviq Saviq added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 699dcde Dec 3, 2024
58 of 65 checks passed
@Saviq Saviq deleted the release/2.19 branch December 3, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saviq Saviq Saviq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@AlanGriffiths @tarek-y-ismail @Conan-Kudo @Saviq