Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We broke the platform ABI since 2.18 #3682

Merged
merged 3 commits into from
Nov 28, 2024
Merged

We broke the platform ABI since 2.18 #3682

merged 3 commits into from
Nov 28, 2024

Conversation

AlanGriffiths
Copy link
Collaborator

As noted in #3590 (review)

@AlanGriffiths AlanGriffiths requested a review from a team as a code owner November 27, 2024 18:17
RAOF
RAOF previously requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're bumping mirplatform ABI we should additionally be combining the stanzas in src/platform/symbols.map into a single 2.19 stanza, right?

@AlanGriffiths
Copy link
Collaborator Author

Since we're bumping mirplatform ABI we should additionally be combining the stanzas in src/platform/symbols.map into a single 2.19 stanza, right?

True

@AlanGriffiths AlanGriffiths requested a review from RAOF November 28, 2024 09:06
Saviq
Saviq approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should additionally be combining the stanzas in src/platform/symbols.map into a single 2.19 stanza, right?

Could our symbols check CI be extended to verify this?

@Saviq Saviq enabled auto-merge November 28, 2024 10:30
@AlanGriffiths AlanGriffiths mentioned this pull request Nov 28, 2024
Open
@Saviq Saviq added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 3c9a7c6 Nov 28, 2024
36 of 39 checks passed
@Saviq Saviq deleted the bump-mirplatform branch November 28, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saviq Saviq Saviq approved these changes

@RAOF RAOF Awaiting requested review from RAOF

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlanGriffiths @Saviq @RAOF