Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lanelet2_map_validator): fixed issue that invalid prerequisites are not reflected to the results #169

Merged
merged 1 commit into from
Dec 5, 2024
+1 −2
Merged

fix(lanelet2_map_validator): fixed issue that invalid prerequisites are not reflected to the results #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions map/autoware_lanelet2_map_validator/src/common/validation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,15 +305,14 @@ void process_requirements(

// Check prerequisites are OK
const auto prerequisite_issues = check_prerequisite_completion(validators, validator_name);
appendIssues(total_issues, prerequisite_issues);

// NOTE: if prerequisite_issues is not empty, skip the content validation process
const auto issues =
prerequisite_issues.empty()
? apply_validation(
lanelet_map, replace_validator(
validator_config.command_line_config.validationConfig, validator_name))
: std::vector<lanelet::validation::DetectedIssues>();
: std::move(prerequisite_issues);

// Add validation results to the json data
json & validator_json = find_validator_block(json_data, validator_name);
Expand Down
Loading