Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lanelet2_map_validator): fixed issue that invalid prerequisites are not reflected to the results #169

Conversation

TaikiYamada4
Copy link
Contributor

Description

This PR fixes the issue that the validation results (lanelet2_validation_results.json) don't reflect the prerequisite failure.
The content in prerequisite_issues should be written in the JSON objects, but the process between L319 to L355 (in validation.cpp) is skipped only for prerequisite_issues.

Related links

None

Tests performed

  • Checked that colcon test has passed.
  • Checked that issues with a message "Prerequisites didn't pass." appear in lanelet2_map_validation_results.json when a incomplete lanelet2 map is given.

Notes for reviewers

Interface changes

Effects on system behavior

Prerequisites failure will appear in the results as expected.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TaikiYamada4 TaikiYamada4 self-assigned this Dec 5, 2024
@TaikiYamada4 TaikiYamada4 changed the title Fixed issue that invalid prerequisites are not reflected to the results fix(lanelet2_map_validator): fixed issue that invalid prerequisites are not reflected to the results Dec 5, 2024
@TaikiYamada4 TaikiYamada4 merged commit 9dd97a3 into autowarefoundation:main Dec 5, 2024
25 of 26 checks passed
@TaikiYamada4 TaikiYamada4 deleted the fix/lanelet2_map_validator/correct_prerequisite_process branch December 5, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants