fix(lanelet2_map_validator): fixed issue that invalid prerequisites are not reflected to the results #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue that the validation results (lanelet2_validation_results.json) don't reflect the prerequisite failure.
The content in
prerequisite_issues
should be written in the JSON objects, but the process between L319 to L355 (in validation.cpp) is skipped only forprerequisite_issues
.Related links
None
Tests performed
colcon test
has passed.lanelet2_map_validation_results.json
when a incomplete lanelet2 map is given.Notes for reviewers
Interface changes
Effects on system behavior
Prerequisites failure will appear in the results as expected.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.