fix(route_handler): creating route at parking lot #8906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ismetatabay <[email protected]>
Signed-off-by: ismetatabay <[email protected]>
ismetatabay
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
5 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At current autoware, the parking scenario cannot initiate sometimes due to route cannot be planned between ego lanelet and closest lanelet to goal pose. However since ego vehicle and goal pose in same parking lot area, we don't need to reject goal due to path planning.
This PR checks whether the start and goal poses are in the same parking lot and sends the start lanelet as the path to initiate other nodes, as a full path is not necessary for freespace planning.
Related links
Parent Issue:
How was this PR tested?
Map File
lanelet2_map.txt
Psim
Before this PR:
2024-09-18.17-07-49.mp4
After this PR:
2024-09-18.17-11-05.mp4
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
autoware_remaining_distance_time_calculator package fails to calculate the time since the package cannot find a route between start and goal lanelet:
autoware.universe/planning/autoware_remaining_distance_time_calculator/src/remaining_distance_time_calculator_node.cpp
Lines 131 to 137 in d57f82d
I am planning to create another PR to disable time calculation in the parking scenario, as the calculation no required during freespace driving.