-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update launch autoware documentation #466
docs: update launch autoware documentation #466
Conversation
Signed-off-by: ismetatabay <[email protected]>
ebd4d74
to
3fa4804
Compare
Signed-off-by: ismetatabay <[email protected]>
3fa4804
to
4b7d39d
Compare
b9dee15
to
ddd3f8b
Compare
Signed-off-by: ismetatabay <[email protected]>
ddd3f8b
to
c7e2c23
Compare
Signed-off-by: ismetatabay <[email protected]>
53ee59c
to
03464d5
Compare
Signed-off-by: ismetatabay <[email protected]>
aa38ee9
to
0484666
Compare
Signed-off-by: ismetatabay <[email protected]>
50302b0
to
58e07af
Compare
Signed-off-by: ismetatabay <[email protected]>
58e07af
to
3108974
Compare
Signed-off-by: ismetatabay <[email protected]>
Signed-off-by: ismetatabay <[email protected]>
29bd05f
to
c2944a9
Compare
@mitsudome-r, Hi mitsudome-san this PR is ready for review |
Signed-off-by: ismetatabay <[email protected]>
Thanks for the PR. I think they are generally good in terms of the information. I think we should refactor the page structure for the How-To-Guides after we merge this PR as discussed before. |
@mitsudome-r Thanks for the review, I will merge this and AWSIM Doc PR (#487) since you approved these PRs. After the reviewing of the tuning PR (#473), I will start refactoring of the documentation pages. Let's talk this issue in the Software WG meeting in Tuesday. Here is my proposal: By the way, we can add these informations in autoware_launch README.mds #:+1: Let's talk this situation in Software WG Meeting also. |
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.