Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update launch autoware documentation #466

Conversation

ismetatabay
Copy link
Member

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: ismetatabay <[email protected]>
@ismetatabay ismetatabay added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Oct 16, 2023
@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Documentation URL: https://autowarefoundation.github.io/autoware-documentation/pr-466/
Modified URLs:

@ismetatabay ismetatabay force-pushed the ismet/doc/update-autoware-launch-doc branch from ebd4d74 to 3fa4804 Compare October 17, 2023 11:52
Signed-off-by: ismetatabay <[email protected]>
@ismetatabay ismetatabay force-pushed the ismet/doc/update-autoware-launch-doc branch from 3fa4804 to 4b7d39d Compare October 17, 2023 11:58
@ismetatabay ismetatabay force-pushed the ismet/doc/update-autoware-launch-doc branch 2 times, most recently from b9dee15 to ddd3f8b Compare October 18, 2023 08:47
Signed-off-by: ismetatabay <[email protected]>
@ismetatabay ismetatabay force-pushed the ismet/doc/update-autoware-launch-doc branch from ddd3f8b to c7e2c23 Compare October 18, 2023 08:56
Signed-off-by: ismetatabay <[email protected]>
@ismetatabay ismetatabay force-pushed the ismet/doc/update-autoware-launch-doc branch from 53ee59c to 03464d5 Compare October 18, 2023 11:56
Signed-off-by: ismetatabay <[email protected]>
@ismetatabay ismetatabay force-pushed the ismet/doc/update-autoware-launch-doc branch from aa38ee9 to 0484666 Compare October 18, 2023 17:12
Signed-off-by: ismetatabay <[email protected]>
@ismetatabay ismetatabay force-pushed the ismet/doc/update-autoware-launch-doc branch from 50302b0 to 58e07af Compare October 20, 2023 14:59
Signed-off-by: ismetatabay <[email protected]>
@ismetatabay ismetatabay force-pushed the ismet/doc/update-autoware-launch-doc branch from 58e07af to 3108974 Compare October 20, 2023 15:01
Signed-off-by: ismetatabay <[email protected]>
Signed-off-by: ismetatabay <[email protected]>
@ismetatabay ismetatabay force-pushed the ismet/doc/update-autoware-launch-doc branch from 29bd05f to c2944a9 Compare October 24, 2023 08:11
@ismetatabay ismetatabay marked this pull request as ready for review October 24, 2023 10:49
@ismetatabay
Copy link
Member Author

@mitsudome-r, Hi mitsudome-san this PR is ready for review

@mitsudome-r
Copy link
Member

Thanks for the PR. I think they are generally good in terms of the information. I think we should refactor the page structure for the How-To-Guides after we merge this PR as discussed before.
(I was also thinking we could move these details to README in the autoware_launch package, but we can discuss that later)

@ismetatabay
Copy link
Member Author

@mitsudome-r Thanks for the review, I will merge this and AWSIM Doc PR (#487) since you approved these PRs. After the reviewing of the tuning PR (#473), I will start refactoring of the documentation pages. Let's talk this issue in the Software WG meeting in Tuesday. Here is my proposal:

aw-documentation-proposal drawio


By the way, we can add these informations in autoware_launch README.mds #:+1: Let's talk this situation in Software WG Meeting also.

@ismetatabay ismetatabay merged commit 5fe0b08 into autowarefoundation:main Dec 1, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants