VK_NV_mesh_shader -> VK_EXT_mesh_shader #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Looks good for me, but this changes break macOS build, please add a stub in MTCommandList. |
andrejnau
reviewed
Oct 29, 2022
andrejnau
reviewed
Oct 29, 2022
| arguments.emplace_back(L"-fspv-extension=KHR"); | ||
| arguments.emplace_back(L"-fspv-extension=SPV_NV_mesh_shader"); | ||
| arguments.emplace_back(L"-fspv-extension=SPV_EXT_mesh_shader"); |
There was a problem hiding this comment.
Unfortunately, DirectXShaderCompiler does not support SPV_EXT_mesh_shader.
There was a problem hiding this comment.
You are right.
I think this pr should remain pending.
andrejnau
force-pushed
the
master
branch
4 times, most recently
from
069a05b
to
2bac18c
Compare
andrejnau
force-pushed
the
master
branch
2 times, most recently
from
40fc172
to
6a266ed
Compare
andrejnau
force-pushed
the
master
branch
2 times, most recently
from
cda9ed4
to
6de34a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need vulkan sdk 1.3.231