Fix some compile warnings

andrejnau · Nov 28, 2023 · 2bac18c · 2bac18c
1 parent f163129
commit 2bac18c
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 15 deletions.
diff --git a/src/FlyCube/CommandQueue/VKCommandQueue.cpp b/src/FlyCube/CommandQueue/VKCommandQueue.cpp
@@ -24,7 +24,7 @@ void VKCommandQueue::Wait(const std::shared_ptr<Fence>& fence, uint64_t value)
  signal_submit_info.pWaitSemaphores = &vk_fence.GetFence();
  vk::PipelineStageFlags wait_dst_stage_mask = vk::PipelineStageFlagBits::eAllCommands;
  signal_submit_info.pWaitDstStageMask = &wait_dst_stage_mask;
- m_queue.submit(1, &signal_submit_info, {});
+ std::ignore = m_queue.submit(1, &signal_submit_info, {});
 }
 
 void VKCommandQueue::Signal(const std::shared_ptr<Fence>& fence, uint64_t value)
@@ -38,7 +38,7 @@ void VKCommandQueue::Signal(const std::shared_ptr<Fence>& fence, uint64_t value)
  signal_submit_info.pNext = &timeline_info;
  signal_submit_info.signalSemaphoreCount = 1;
  signal_submit_info.pSignalSemaphores = &vk_fence.GetFence();
- m_queue.submit(1, &signal_submit_info, {});
+ std::ignore = m_queue.submit(1, &signal_submit_info, {});
 }
 
 void VKCommandQueue::ExecuteCommandLists(const std::vector<std::shared_ptr<CommandList>>& command_lists)
@@ -59,7 +59,7 @@ void VKCommandQueue::ExecuteCommandLists(const std::vector<std::shared_ptr<Comma
  vk::PipelineStageFlags wait_dst_stage_mask = vk::PipelineStageFlagBits::eAllCommands;
  submit_info.pWaitDstStageMask = &wait_dst_stage_mask;
 
- m_queue.submit(1, &submit_info, {});
+ std::ignore = m_queue.submit(1, &submit_info, {});
 }
 
 VKDevice& VKCommandQueue::GetDevice()

diff --git a/src/FlyCube/Fence/VKTimelineSemaphore.cpp b/src/FlyCube/Fence/VKTimelineSemaphore.cpp
@@ -24,7 +24,7 @@ void VKTimelineSemaphore::Wait(uint64_t value)
  wait_info.semaphoreCount = 1;
  wait_info.pSemaphores = &m_timeline_semaphore.get();
  wait_info.pValues = &value;
- m_device.GetDevice().waitSemaphoresKHR(wait_info, UINT64_MAX);
+ std::ignore = m_device.GetDevice().waitSemaphoresKHR(wait_info, UINT64_MAX);
 }
 
 void VKTimelineSemaphore::Signal(uint64_t value)

diff --git a/src/FlyCube/Resource/VKResource.cpp b/src/FlyCube/Resource/VKResource.cpp
@@ -94,7 +94,8 @@ void VKResource::SetName(const std::string& name)
 uint8_t* VKResource::Map()
 {
  uint8_t* dst_data = nullptr;
- m_device.GetDevice().mapMemory(m_vk_memory, 0, VK_WHOLE_SIZE, {}, reinterpret_cast<void**>(&dst_data));
+ std::ignore =
+ m_device.GetDevice().mapMemory(m_vk_memory, 0, VK_WHOLE_SIZE, {}, reinterpret_cast<void**>(&dst_data));
  return dst_data;
 }
 

diff --git a/src/FlyCube/ShaderReflection/test/main.cpp b/src/FlyCube/ShaderReflection/test/main.cpp
@@ -31,7 +31,7 @@ class RayTracing : public ShaderTestCase {
  return m_desc;
  }
 
- void Test(ShaderBlobType type, const void* data, size_t size) const
+ void Test(ShaderBlobType type, const void* data, size_t size) const override
  {
  REQUIRE(data);
  REQUIRE(size);
@@ -63,7 +63,7 @@ class TrianglePS : public ShaderTestCase {
  return m_desc;
  }
 
- void Test(ShaderBlobType type, const void* data, size_t size) const
+ void Test(ShaderBlobType type, const void* data, size_t size) const override
  {
  REQUIRE(data);
  REQUIRE(size);
@@ -92,7 +92,7 @@ class TriangleVS : public ShaderTestCase {
  return m_desc;
  }
 
- void Test(ShaderBlobType type, const void* data, size_t size) const
+ void Test(ShaderBlobType type, const void* data, size_t size) const override
  {
  REQUIRE(data);
  REQUIRE(size);

diff --git a/src/FlyCube/Swapchain/VKSwapchain.cpp b/src/FlyCube/Swapchain/VKSwapchain.cpp
@@ -62,8 +62,8 @@ VKSwapchain::VKSwapchain(VKCommandQueue& command_queue,
  ASSERT(surface_capabilities.currentExtent.height == height);
 
  vk::Bool32 is_supported_surface = VK_FALSE;
- adapter.GetPhysicalDevice().getSurfaceSupportKHR(command_queue.GetQueueFamilyIndex(), m_surface.get(),
- &is_supported_surface);
+ std::ignore = adapter.GetPhysicalDevice().getSurfaceSupportKHR(command_queue.GetQueueFamilyIndex(), m_surface.get(),
+  &is_supported_surface);
  ASSERT(is_supported_surface);
 
  auto modes = adapter.GetPhysicalDevice().getSurfacePresentModesKHR(m_surface.get());
@@ -138,8 +138,8 @@ std::shared_ptr<Resource> VKSwapchain::GetBackBuffer(uint32_t buffer)
 
 uint32_t VKSwapchain::NextImage(const std::shared_ptr<Fence>& fence, uint64_t signal_value)
 {
- m_device.GetDevice().acquireNextImageKHR(m_swapchain.get(), UINT64_MAX, m_image_available_semaphore.get(), nullptr,
- &m_frame_index);
+ std::ignore = m_device.GetDevice().acquireNextImageKHR(m_swapchain.get(), UINT64_MAX,
+  m_image_available_semaphore.get(), nullptr, &m_frame_index);
 
  decltype(auto) vk_fence = fence->As<VKTimelineSemaphore>();
  uint64_t tmp = std::numeric_limits<uint64_t>::max();
@@ -156,7 +156,7 @@ uint32_t VKSwapchain::NextImage(const std::shared_ptr<Fence>& fence, uint64_t si
  signal_submit_info.pWaitDstStageMask = &waitDstStageMask;
  signal_submit_info.signalSemaphoreCount = 1;
  signal_submit_info.pSignalSemaphores = &vk_fence.GetFence();
- m_command_queue.GetQueue().submit(1, &signal_submit_info, {});
+ std::ignore = m_command_queue.GetQueue().submit(1, &signal_submit_info, {});
 
  return m_frame_index;
 }
@@ -178,13 +178,13 @@ void VKSwapchain::Present(const std::shared_ptr<Fence>& fence, uint64_t wait_val
  signal_submit_info.pWaitDstStageMask = &waitDstStageMask;
  signal_submit_info.signalSemaphoreCount = 1;
  signal_submit_info.pSignalSemaphores = &m_rendering_finished_semaphore.get();
- m_command_queue.GetQueue().submit(1, &signal_submit_info, {});
+ std::ignore = m_command_queue.GetQueue().submit(1, &signal_submit_info, {});
 
  vk::PresentInfoKHR present_info = {};
  present_info.swapchainCount = 1;
  present_info.pSwapchains = &m_swapchain.get();
  present_info.pImageIndices = &m_frame_index;
  present_info.waitSemaphoreCount = 1;
  present_info.pWaitSemaphores = &m_rendering_finished_semaphore.get();
- m_command_queue.GetQueue().presentKHR(present_info);
+ std::ignore = m_command_queue.GetQueue().presentKHR(present_info);
 }