Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI update #1713

Closed
wants to merge 1 commit into from
Closed

CI update #1713

wants to merge 1 commit into from

Conversation

j-stephan
Copy link
Member

@j-stephan j-stephan commented May 10, 2022

Summary:

Fixes #1670. Fixes #1708. Fixes #1724.

@j-stephan
Copy link
Member Author

Wow, case in point: One of our C++20 jobs is failing with Boost 1.79.0. Apparently Boost.fiber is internally using std::result_of which was removed in C++20.

From Boost.fiber's documentation:

Boost.fiber requires C++11!

So I guess we need to start thinking about the future of this back-end.

@bernhardmgruber
Copy link
Member

Wow, case in point: One of our C++20 jobs is failing with Boost 1.79.0. Apparently Boost.fiber is internally using std::result_of which was removed in C++20.

That was fixed 15 days ago: boostorg/fiber@a6b64c9

However, that still leaves Boost.Fiber 1.79 and below problematic with C++20.

@bernhardmgruber
Copy link
Member

It seems g++-12 is not installed:

2022-05-10T17:06:01.9941211Z +++ sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-12 50
2022-05-10T17:06:01.9987407Z update-alternatives: error: alternative path /usr/bin/g++-12 doesn't exist

@j-stephan
Copy link
Member Author

You're right. apt install g++-12 leads to an installation of clang-12 for some reason. Maybe it cannot find g++-12 and does some guesswork. 🤡

@j-stephan
Copy link
Member Author

Rebased and added the following changes:

  • added CUDA 11.7 to CI
  • CUDA 11.6 tests now use CUDA 11.6.2
  • gcc-12 jobs will use GitHub's ubuntu-22.04 runners

@j-stephan j-stephan force-pushed the compilers branch 5 times, most recently from f1daaad to ddf34f2 Compare May 20, 2022 11:45
@j-stephan
Copy link
Member Author

  • gcc-12 jobs are failing because there is a Docker bug in the ubuntu-22.04 runners. This has been fixed but is apparently still in the rollout phase.
  • clang-14-asan is failing because of a bug in one of our test cases. We need to investigate this.

@j-stephan j-stephan force-pushed the compilers branch 4 times, most recently from 6c0e896 to 2a37179 Compare May 20, 2022 12:59
@jkelling
Copy link
Member

jkelling commented Jun 8, 2022

While you are at it: Could you please change the build type of check with enabled sanitizer which are currently Release to RelWithDebInfo to make the printed backtraces more useful? (e.g. linux_clang-6_release_asan, I do not know if there are others)

@j-stephan
Copy link
Member Author

While you are at it: Could you please change the build type of check with enabled sanitizer which are currently Release to RelWithDebInfo to make the printed backtraces more useful?

Done.

@j-stephan j-stephan force-pushed the compilers branch 3 times, most recently from d4ba909 to 125f774 Compare June 27, 2022 11:59
@j-stephan j-stephan force-pushed the compilers branch 2 times, most recently from eb018e6 to 40e920e Compare June 29, 2022 07:37
@j-stephan
Copy link
Member Author

Note: The macOS 10.15 runners have been deprecated by GitHub and will be removed at the end of August. I therefore removed our macOS 10.15 tests from the CI which will be visible upon my next push (after merging #1754 and #1755).

@psychocoderHPC
Copy link
Member

I am a little bit unhappy that this PR is mixing features, refactorings, and adding new test combinations.

Could you split e.g CUDA keyring refactorings, job renamings and new jobs into separate PRs? This would also simplify the review and give us a better overview of why a CI job is failing.

@j-stephan
Copy link
Member Author

And so it shall be done. I will prepare a number of successor PRs and close this one afterwards.

script/install_clang.sh Show resolved Hide resolved
script/install_clang.sh Show resolved Hide resolved
@j-stephan
Copy link
Member Author

All points from the original description have been addressed.

@j-stephan j-stephan closed this Jan 16, 2023
@j-stephan j-stephan deleted the compilers branch January 17, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CUDA 11.7 Add gcc-12 to CI Add clang-14 to CI
4 participants