Fix RuntimeError when re-ordering filters within an Alert Profiles filter group

changelog.d/2979.fixed.md

@@ -0,0 +1 @@
+Fix crash bug when reordering filters within a filter group in Alert Profiles

python/nav/web/alertprofiles/views.py

@@ -2050,7 +2050,7 @@ def filter_group_addfilter(request):
 def filter_group_remove_or_move_filter(request):
     """Deletes or moves around a filter within a filter group"""
     post = request.POST.copy()
-    for name in post:
+    for name in request.POST:
         if name.find("=") != -1:
             attribute, value = name.split("=")
             del post[name]

tests/integration/web/alertprofiles_test.py

@@ -1029,6 +1029,23 @@ def test_alertprofiles_remove_filter_group(self, db, client, dummy_filter_group)
         assert dummy_filter_group.name in smart_str(response.content)
         assert FilterGroup.objects.filter(pk=dummy_filter_group.pk).count() == 1
 
+    def test_alertprofiles_move_filter_within_group_should_not_crash(
+        self, db, client, dummy_filter_group
+    ):
+        """Regression test for #2979: Ensuring that pre-processing of request data
+        doesn't crash unexpectedly.
+        """
+        url = reverse('alertprofiles-filter_groups-removefilter')
+        response = client.post(
+            url,
+            follow=True,
+            data={
+                "moveup=23": "Move+up",
+                "id": dummy_filter_group.id,
+            },
+        )
+        assert response.status_code in (200, 404)
+
 
 #
 # fixtures and helpers