Fix RuntimeError when re-ordering filters within an Alert Profiles filter group #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a Python 2-ism that got lost in the conversion to Python 3 a few years back: The code would iterate over a dictionary while potentially making modifications to it, and you cannot do that under Python 3. This fixes it by instead just iterating over the keys of the original dictionary that was copied.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2980 +/- ##
==========================================
+ Coverage 56.37% 56.42% +0.05%
==========================================
Files 602 602
Lines 43813 43813
Branches 48 48
==========================================
+ Hits 24700 24722 +22
+ Misses 19101 19079 -22
Partials 12 12 ☔ View full report in Codecov by Sentry. |
johannaengland
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2979